From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55303) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VLSe7-0008Jg-L8 for qemu-devel@nongnu.org; Mon, 16 Sep 2013 02:51:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VLSdy-0001PK-Ld for qemu-devel@nongnu.org; Mon, 16 Sep 2013 02:50:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26631) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VLSdy-0001P5-E0 for qemu-devel@nongnu.org; Mon, 16 Sep 2013 02:50:46 -0400 From: Fam Zheng Date: Mon, 16 Sep 2013 14:50:20 +0800 Message-Id: <1379314227-8855-2-git-send-email-famz@redhat.com> In-Reply-To: <1379314227-8855-1-git-send-email-famz@redhat.com> References: <1379314227-8855-1-git-send-email-famz@redhat.com> Subject: [Qemu-devel] [PATCH v10 1/8] ui/Makefile.objs: delete unnecessary cocoa.o dependency List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, famz@redhat.com, mjt@tls.msk.ru, alex@alex.org.uk, pbonzini@redhat.com, vilanova@ac.upc.edu, rth@twiddle.net From: Peter Maydell Delete an unnecessary dependency for cocoa.o; we already have a general rule that tells Make that we can build a .o file from a .m source using an ObjC compiler, so this specific rule is unnecessary. Further, it is using the dubious construct "$(SRC_PATH)/$(obj)" to get at the source directory, which will break when $(obj) is redefined as part of the preparation for per-object library support. Signed-off-by: Peter Maydell Signed-off-by: Fam Zheng --- ui/Makefile.objs | 2 -- 1 file changed, 2 deletions(-) diff --git a/ui/Makefile.objs b/ui/Makefile.objs index 6ddc0de..f33be47 100644 --- a/ui/Makefile.objs +++ b/ui/Makefile.objs @@ -17,6 +17,4 @@ common-obj-$(CONFIG_GTK) += gtk.o x_keymap.o $(obj)/sdl.o $(obj)/sdl_zoom.o: QEMU_CFLAGS += $(SDL_CFLAGS) -$(obj)/cocoa.o: $(SRC_PATH)/$(obj)/cocoa.m - $(obj)/gtk.o: QEMU_CFLAGS += $(GTK_CFLAGS) $(VTE_CFLAGS) -- 1.8.3.1