From: Gerd Hoffmann <kraxel@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: peter.maydell@linaro.org, famz@redhat.com, mjt@tls.msk.ru,
qemu-devel@nongnu.org, alex@alex.org.uk, vilanova@ac.upc.edu,
rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH v10 5/8] module: implement module loading
Date: Mon, 16 Sep 2013 12:57:17 +0200 [thread overview]
Message-ID: <1379329037.7114.35.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <5236D8EB.9060700@redhat.com>
Hi,
> With this patch, a module will not be able to use the module_init macro
> twice. I am not sure this is an acceptable limitation, especially if we
> do not have a dependency system within modules and/or load them with
> G_MODULE_LOCAL/RTLD_LOCAL.
Exactly. To modularize spice we need either inter-module dependencies,
so spice-audio.mo can depend on spice-core.mo etc, or allow multiple
module_init calls so we can link all spice components into one big
spice.mo module and each component can use module_init.
It's not mandatory for the initial revision, we'll need a bit more (like
registering monitor commands for 'info spice') so we can actually
modularize spice. But it should definitively on the radar for the
planning ...
cheers,
Gerd
next prev parent reply other threads:[~2013-09-16 10:57 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 6:50 [Qemu-devel] [PATCH v10 0/8] Shared Library Module Support Fam Zheng
2013-09-16 6:50 ` [Qemu-devel] [PATCH v10 1/8] ui/Makefile.objs: delete unnecessary cocoa.o dependency Fam Zheng
2013-09-16 6:50 ` [Qemu-devel] [PATCH v10 2/8] make.rule: fix $(obj) to a real relative path Fam Zheng
2013-09-16 6:50 ` [Qemu-devel] [PATCH v10 3/8] rule.mak: allow per object cflags and libs Fam Zheng
2013-09-16 6:50 ` [Qemu-devel] [PATCH v10 4/8] build-sys: introduce common-obj-m and block-obj-m for DSO Fam Zheng
2013-09-16 6:50 ` [Qemu-devel] [PATCH v10 5/8] module: implement module loading Fam Zheng
2013-09-16 8:59 ` Daniel P. Berrange
2013-09-16 9:28 ` Fam Zheng
2013-09-16 22:16 ` Richard Henderson
2013-09-17 0:47 ` Fam Zheng
2013-09-16 9:44 ` Paolo Bonzini
2013-09-16 9:51 ` Fam Zheng
2013-09-16 10:09 ` Paolo Bonzini
2013-09-16 10:14 ` Daniel P. Berrange
2013-09-16 10:18 ` Paolo Bonzini
2013-09-16 10:21 ` Daniel P. Berrange
2013-09-16 10:30 ` Paolo Bonzini
2013-09-16 11:29 ` Fam Zheng
2013-09-16 11:33 ` Paolo Bonzini
2013-09-16 11:46 ` Fam Zheng
2013-09-16 22:31 ` Richard Henderson
2013-09-17 1:29 ` Fam Zheng
2013-09-17 5:40 ` Richard Henderson
2013-09-18 11:45 ` Paolo Bonzini
2013-09-18 14:44 ` Richard Henderson
2013-09-18 15:00 ` Paolo Bonzini
2013-09-17 8:50 ` Wenchao Xia
2013-09-16 10:57 ` Gerd Hoffmann [this message]
2013-09-16 11:00 ` Paolo Bonzini
2013-09-16 22:38 ` Richard Henderson
2013-09-16 10:24 ` Alex Bligh
2013-09-16 10:38 ` Paolo Bonzini
2013-09-16 11:00 ` Alex Bligh
2013-09-16 11:04 ` Daniel P. Berrange
2013-09-16 11:27 ` Alex Bligh
2013-09-16 11:08 ` Paolo Bonzini
2013-09-16 11:30 ` Alex Bligh
2013-09-17 8:26 ` Wenchao Xia
2013-09-16 10:43 ` Fam Zheng
2013-09-16 11:05 ` Daniel P. Berrange
2013-09-16 12:36 ` Gerd Hoffmann
2013-09-17 5:55 ` Fam Zheng
2013-09-17 6:33 ` Alex Bligh
2013-09-17 6:40 ` Fam Zheng
2013-09-16 6:50 ` [Qemu-devel] [PATCH v10 6/8] Makefile: install modules with "make install" Fam Zheng
2013-09-16 6:50 ` [Qemu-devel] [PATCH v10 7/8] .gitignore: ignore module related files (dll, so, mo) Fam Zheng
2013-09-16 6:50 ` [Qemu-devel] [PATCH v10 8/8] block: convert block drivers linked with libs to modules Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379329037.7114.35.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=alex@alex.org.uk \
--cc=famz@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).