From: Peter Lieven <pl@kamp.de>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, ronniesahlberg@gmail.com,
Peter Lieven <pl@kamp.de>,
stefanha@redhat.com, anthony@codemonkey.ws, pbonzini@redhat.com
Subject: [Qemu-devel] [PATCHv2 13/20] block: introduce bdrv_zeroize
Date: Tue, 17 Sep 2013 15:48:49 +0200 [thread overview]
Message-ID: <1379425736-11326-14-git-send-email-pl@kamp.de> (raw)
In-Reply-To: <1379425736-11326-1-git-send-email-pl@kamp.de>
this patch adds a call to completely zero out a block device.
the operation is sped up by checking the block status and
only writing zeroes to the device if they currently do not
return zeroes. optionally the zero writing can be sped up
by setting the flag BDRV_REQ_MAY_UNMAP to emulate the zero
write by unmapping if the driver supports it.
Signed-off-by: Peter Lieven <pl@kamp.de>
---
block.c | 30 ++++++++++++++++++++++++++++++
include/block/block.h | 1 +
2 files changed, 31 insertions(+)
diff --git a/block.c b/block.c
index ecc5be4..88b137c 100644
--- a/block.c
+++ b/block.c
@@ -2342,6 +2342,36 @@ int bdrv_write_zeroes(BlockDriverState *bs, int64_t sector_num,
BDRV_REQ_ZERO_WRITE | flags);
}
+int bdrv_zeroize(BlockDriverState *bs, BdrvRequestFlags flags)
+{
+ int64_t target_size = bdrv_getlength(bs) / BDRV_SECTOR_SIZE;
+ int64_t ret, nb_sectors, sector_num = 0;
+ int n;
+ /* split the write requests into 1MB chunks if the driver
+ * does not return a maximal size via bdi */
+ for (;;) {
+ nb_sectors = target_size - sector_num;
+ if (nb_sectors <= 0) {
+ return 0;
+ }
+ if (nb_sectors > INT_MAX) {
+ nb_sectors = INT_MAX;
+ }
+ ret = bdrv_get_block_status(bs, sector_num, nb_sectors, &n);
+ if (ret & BDRV_BLOCK_ZERO) {
+ sector_num += n;
+ continue;
+ }
+ ret = bdrv_write_zeroes(bs, sector_num, n, flags & BDRV_REQ_MAY_UNMAP);
+ if (ret < 0) {
+ error_report("error writing zeroes at sector %" PRId64 ": %s",
+ sector_num, strerror(-ret));
+ return -EIO;
+ }
+ sector_num += n;
+ }
+}
+
int bdrv_pread(BlockDriverState *bs, int64_t offset,
void *buf, int count1)
{
diff --git a/include/block/block.h b/include/block/block.h
index 8aa325a..a45166e 100644
--- a/include/block/block.h
+++ b/include/block/block.h
@@ -195,6 +195,7 @@ int bdrv_write(BlockDriverState *bs, int64_t sector_num,
const uint8_t *buf, int nb_sectors);
int bdrv_write_zeroes(BlockDriverState *bs, int64_t sector_num,
int nb_sectors, BdrvRequestFlags flags);
+int bdrv_zeroize(BlockDriverState *bs, BdrvRequestFlags flags);
int bdrv_writev(BlockDriverState *bs, int64_t sector_num, QEMUIOVector *qiov);
int bdrv_pread(BlockDriverState *bs, int64_t offset,
void *buf, int count);
--
1.7.9.5
next prev parent reply other threads:[~2013-09-17 13:51 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 13:48 [Qemu-devel] [PATCHv2 00/20] block: logical block provisioning enhancements Peter Lieven
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 01/20] block: make BdrvRequestFlags public Peter Lieven
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 02/20] block: add flags to bdrv_*_write_zeroes Peter Lieven
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 03/20] block: introduce BDRV_REQ_MAY_UNMAP request flag Peter Lieven
2013-09-19 12:02 ` Eric Blake
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 04/20] block: introduce bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes Peter Lieven
2013-09-19 14:46 ` Eric Blake
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 05/20] block/raw: add " Peter Lieven
2013-09-19 18:48 ` Eric Blake
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 06/20] block: add discard and write_zeroes limits and alignment to BlockDriverState Peter Lieven
2013-09-19 18:53 ` Eric Blake
2013-09-19 19:11 ` Peter Lieven
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 07/20] block: honour alignment and limit in bdrv_co_do_write_zeroes Peter Lieven
2013-09-19 20:07 ` Eric Blake
2013-09-19 21:57 ` Peter Lieven
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 08/20] block: honour alignment and limit in bdrv_co_discard Peter Lieven
2013-09-19 20:09 ` Eric Blake
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 09/20] iscsi: simplify iscsi_co_discard Peter Lieven
2013-09-19 20:12 ` Eric Blake
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 10/20] iscsi: set limits in BlockDriverState Peter Lieven
2013-09-19 20:14 ` Eric Blake
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 11/20] iscsi: add bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes Peter Lieven
2013-09-19 20:17 ` Eric Blake
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 12/20] iscsi: add bdrv_co_write_zeroes Peter Lieven
2013-09-19 20:19 ` Eric Blake
2013-09-17 13:48 ` Peter Lieven [this message]
2013-09-19 20:26 ` [Qemu-devel] [PATCHv2 13/20] block: introduce bdrv_zeroize Eric Blake
2013-09-19 21:52 ` Peter Lieven
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 14/20] block/get_block_status: set *pnum = 0 on error Peter Lieven
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 15/20] block/get_block_status: avoid segfault if there is no backing_hd Peter Lieven
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 16/20] block/get_block_status: avoid redundant callouts on raw devices Peter Lieven
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 17/20] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks Peter Lieven
2013-09-19 20:30 ` Eric Blake
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 18/20] qemu-img: add support for fully allocated images Peter Lieven
2013-09-19 20:36 ` Eric Blake
2013-09-19 21:50 ` Peter Lieven
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 19/20] qemu-img: conditionally zero out target on convert Peter Lieven
2013-09-19 20:39 ` Eric Blake
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 20/20] block/raw: copy block limits and alignment information on raw_open Peter Lieven
2013-09-18 8:48 ` Paolo Bonzini
2013-09-19 7:29 ` Peter Lieven
2013-09-19 14:44 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379425736-11326-14-git-send-email-pl@kamp.de \
--to=pl@kamp.de \
--cc=anthony@codemonkey.ws \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).