qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Lieven <pl@kamp.de>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, ronniesahlberg@gmail.com,
	Peter Lieven <pl@kamp.de>,
	stefanha@redhat.com, anthony@codemonkey.ws, pbonzini@redhat.com
Subject: [Qemu-devel] [PATCHv2 14/20] block/get_block_status: set *pnum = 0 on error
Date: Tue, 17 Sep 2013 15:48:50 +0200	[thread overview]
Message-ID: <1379425736-11326-15-git-send-email-pl@kamp.de> (raw)
In-Reply-To: <1379425736-11326-1-git-send-email-pl@kamp.de>

if the call is invoked through bdrv_is_allocated the caller might
expect *pnum = 0 on error. however, a new implementation of
bdrv_get_block_status might only return a negative exit value on
error while keeping *pnum untouched.

Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Peter Lieven <pl@kamp.de>
---
 block.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/block.c b/block.c
index 88b137c..805ee26 100644
--- a/block.c
+++ b/block.c
@@ -3188,6 +3188,7 @@ static int64_t coroutine_fn bdrv_co_get_block_status(BlockDriverState *bs,
 
     ret = bs->drv->bdrv_co_get_block_status(bs, sector_num, nb_sectors, pnum);
     if (ret < 0) {
+        *pnum = 0;
         return ret;
     }
 
-- 
1.7.9.5

  parent reply	other threads:[~2013-09-17 13:51 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-17 13:48 [Qemu-devel] [PATCHv2 00/20] block: logical block provisioning enhancements Peter Lieven
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 01/20] block: make BdrvRequestFlags public Peter Lieven
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 02/20] block: add flags to bdrv_*_write_zeroes Peter Lieven
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 03/20] block: introduce BDRV_REQ_MAY_UNMAP request flag Peter Lieven
2013-09-19 12:02   ` Eric Blake
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 04/20] block: introduce bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes Peter Lieven
2013-09-19 14:46   ` Eric Blake
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 05/20] block/raw: add " Peter Lieven
2013-09-19 18:48   ` Eric Blake
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 06/20] block: add discard and write_zeroes limits and alignment to BlockDriverState Peter Lieven
2013-09-19 18:53   ` Eric Blake
2013-09-19 19:11     ` Peter Lieven
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 07/20] block: honour alignment and limit in bdrv_co_do_write_zeroes Peter Lieven
2013-09-19 20:07   ` Eric Blake
2013-09-19 21:57     ` Peter Lieven
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 08/20] block: honour alignment and limit in bdrv_co_discard Peter Lieven
2013-09-19 20:09   ` Eric Blake
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 09/20] iscsi: simplify iscsi_co_discard Peter Lieven
2013-09-19 20:12   ` Eric Blake
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 10/20] iscsi: set limits in BlockDriverState Peter Lieven
2013-09-19 20:14   ` Eric Blake
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 11/20] iscsi: add bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes Peter Lieven
2013-09-19 20:17   ` Eric Blake
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 12/20] iscsi: add bdrv_co_write_zeroes Peter Lieven
2013-09-19 20:19   ` Eric Blake
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 13/20] block: introduce bdrv_zeroize Peter Lieven
2013-09-19 20:26   ` Eric Blake
2013-09-19 21:52     ` Peter Lieven
2013-09-17 13:48 ` Peter Lieven [this message]
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 15/20] block/get_block_status: avoid segfault if there is no backing_hd Peter Lieven
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 16/20] block/get_block_status: avoid redundant callouts on raw devices Peter Lieven
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 17/20] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks Peter Lieven
2013-09-19 20:30   ` Eric Blake
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 18/20] qemu-img: add support for fully allocated images Peter Lieven
2013-09-19 20:36   ` Eric Blake
2013-09-19 21:50     ` Peter Lieven
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 19/20] qemu-img: conditionally zero out target on convert Peter Lieven
2013-09-19 20:39   ` Eric Blake
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 20/20] block/raw: copy block limits and alignment information on raw_open Peter Lieven
2013-09-18  8:48   ` Paolo Bonzini
2013-09-19  7:29     ` Peter Lieven
2013-09-19 14:44       ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1379425736-11326-15-git-send-email-pl@kamp.de \
    --to=pl@kamp.de \
    --cc=anthony@codemonkey.ws \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=ronniesahlberg@gmail.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).