From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55950) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VLvh0-0007d8-Ou for qemu-devel@nongnu.org; Tue, 17 Sep 2013 09:51:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VLvgt-0001zn-2n for qemu-devel@nongnu.org; Tue, 17 Sep 2013 09:51:50 -0400 Received: from mx.ipv6.kamp.de ([2a02:248:0:51::16]:59397 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VLvgs-0001zK-Mg for qemu-devel@nongnu.org; Tue, 17 Sep 2013 09:51:43 -0400 From: Peter Lieven Date: Tue, 17 Sep 2013 15:48:50 +0200 Message-Id: <1379425736-11326-15-git-send-email-pl@kamp.de> In-Reply-To: <1379425736-11326-1-git-send-email-pl@kamp.de> References: <1379425736-11326-1-git-send-email-pl@kamp.de> Subject: [Qemu-devel] [PATCHv2 14/20] block/get_block_status: set *pnum = 0 on error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, ronniesahlberg@gmail.com, Peter Lieven , stefanha@redhat.com, anthony@codemonkey.ws, pbonzini@redhat.com if the call is invoked through bdrv_is_allocated the caller might expect *pnum = 0 on error. however, a new implementation of bdrv_get_block_status might only return a negative exit value on error while keeping *pnum untouched. Reviewed-by: Eric Blake Signed-off-by: Peter Lieven --- block.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block.c b/block.c index 88b137c..805ee26 100644 --- a/block.c +++ b/block.c @@ -3188,6 +3188,7 @@ static int64_t coroutine_fn bdrv_co_get_block_status(BlockDriverState *bs, ret = bs->drv->bdrv_co_get_block_status(bs, sector_num, nb_sectors, pnum); if (ret < 0) { + *pnum = 0; return ret; } -- 1.7.9.5