From: Peter Lieven <pl@kamp.de>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, ronniesahlberg@gmail.com,
Peter Lieven <pl@kamp.de>,
stefanha@redhat.com, anthony@codemonkey.ws, pbonzini@redhat.com
Subject: [Qemu-devel] [PATCHv2 18/20] qemu-img: add support for fully allocated images
Date: Tue, 17 Sep 2013 15:48:54 +0200 [thread overview]
Message-ID: <1379425736-11326-19-git-send-email-pl@kamp.de> (raw)
In-Reply-To: <1379425736-11326-1-git-send-email-pl@kamp.de>
Signed-off-by: Peter Lieven <pl@kamp.de>
---
qemu-img.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index 3e5e388..7600b58 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -100,8 +100,10 @@ static void help(void)
" '-h' with or without a command shows this help and lists the supported formats\n"
" '-p' show progress of command (only certain commands)\n"
" '-q' use Quiet mode - do not print any output (except errors)\n"
- " '-S' indicates the consecutive number of bytes that must contain only zeros\n"
- " for qemu-img to create a sparse image during conversion\n"
+ " '-S' indicates the consecutive number of bytes (defaults to 4096) that must\n"
+ " contain only zeros for qemu-img to create a sparse image during\n"
+ " conversion. if the number of bytes is 0 sparse files are disabled and\n"
+ " images will always be fully allocated\n"
" '--output' takes the format in which the output must be done (human or json)\n"
" '-n' skips the target volume creation (useful if the volume is created\n"
" prior to running qemu-img)\n"
@@ -1468,7 +1470,7 @@ static int img_convert(int argc, char **argv)
/* signal EOF to align */
bdrv_write_compressed(out_bs, 0, NULL, 0);
} else {
- int has_zero_init = bdrv_has_zero_init(out_bs);
+ int has_zero_init = min_sparse ? bdrv_has_zero_init(out_bs) : 0;
sector_num = 0; // total number of sectors converted so far
nb_sectors = total_sectors - sector_num;
--
1.7.9.5
next prev parent reply other threads:[~2013-09-17 13:58 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 13:48 [Qemu-devel] [PATCHv2 00/20] block: logical block provisioning enhancements Peter Lieven
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 01/20] block: make BdrvRequestFlags public Peter Lieven
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 02/20] block: add flags to bdrv_*_write_zeroes Peter Lieven
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 03/20] block: introduce BDRV_REQ_MAY_UNMAP request flag Peter Lieven
2013-09-19 12:02 ` Eric Blake
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 04/20] block: introduce bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes Peter Lieven
2013-09-19 14:46 ` Eric Blake
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 05/20] block/raw: add " Peter Lieven
2013-09-19 18:48 ` Eric Blake
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 06/20] block: add discard and write_zeroes limits and alignment to BlockDriverState Peter Lieven
2013-09-19 18:53 ` Eric Blake
2013-09-19 19:11 ` Peter Lieven
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 07/20] block: honour alignment and limit in bdrv_co_do_write_zeroes Peter Lieven
2013-09-19 20:07 ` Eric Blake
2013-09-19 21:57 ` Peter Lieven
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 08/20] block: honour alignment and limit in bdrv_co_discard Peter Lieven
2013-09-19 20:09 ` Eric Blake
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 09/20] iscsi: simplify iscsi_co_discard Peter Lieven
2013-09-19 20:12 ` Eric Blake
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 10/20] iscsi: set limits in BlockDriverState Peter Lieven
2013-09-19 20:14 ` Eric Blake
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 11/20] iscsi: add bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes Peter Lieven
2013-09-19 20:17 ` Eric Blake
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 12/20] iscsi: add bdrv_co_write_zeroes Peter Lieven
2013-09-19 20:19 ` Eric Blake
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 13/20] block: introduce bdrv_zeroize Peter Lieven
2013-09-19 20:26 ` Eric Blake
2013-09-19 21:52 ` Peter Lieven
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 14/20] block/get_block_status: set *pnum = 0 on error Peter Lieven
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 15/20] block/get_block_status: avoid segfault if there is no backing_hd Peter Lieven
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 16/20] block/get_block_status: avoid redundant callouts on raw devices Peter Lieven
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 17/20] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks Peter Lieven
2013-09-19 20:30 ` Eric Blake
2013-09-17 13:48 ` Peter Lieven [this message]
2013-09-19 20:36 ` [Qemu-devel] [PATCHv2 18/20] qemu-img: add support for fully allocated images Eric Blake
2013-09-19 21:50 ` Peter Lieven
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 19/20] qemu-img: conditionally zero out target on convert Peter Lieven
2013-09-19 20:39 ` Eric Blake
2013-09-17 13:48 ` [Qemu-devel] [PATCHv2 20/20] block/raw: copy block limits and alignment information on raw_open Peter Lieven
2013-09-18 8:48 ` Paolo Bonzini
2013-09-19 7:29 ` Peter Lieven
2013-09-19 14:44 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379425736-11326-19-git-send-email-pl@kamp.de \
--to=pl@kamp.de \
--cc=anthony@codemonkey.ws \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).