From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Alexander Graf <agraf@suse.de>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
Jens Freimann <jfrei@linux.vnet.ibm.com>,
Heinz Graalfs <graalfs@linux.vnet.ibm.com>,
Ralf Hoppe <rhoppe@de.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] [PATCH 06/11] s390/eventfacility: fix multiple Read Event Data sources
Date: Wed, 18 Sep 2013 12:19:27 +0200 [thread overview]
Message-ID: <1379499572-49737-7-git-send-email-borntraeger@de.ibm.com> (raw)
In-Reply-To: <1379499572-49737-1-git-send-email-borntraeger@de.ibm.com>
From: Ralf Hoppe <rhoppe@de.ibm.com>
Make the handler for SCLP Read Event Data deal with notifications
for multiple sources correctly.
Signed-off-by: Ralf Hoppe <rhoppe@de.ibm.com>
Reviewed-by: Thomas Huth <thuth@linux.vnet.ibm.com>
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
[split bigger patch into smaller independent chunks]
---
hw/s390x/event-facility.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/s390x/event-facility.c b/hw/s390x/event-facility.c
index c8f62bf..4347a48 100644
--- a/hw/s390x/event-facility.c
+++ b/hw/s390x/event-facility.c
@@ -183,7 +183,7 @@ static uint16_t handle_sccb_read_events(SCLPEventFacility *ef, SCCB *sccb,
{
uint16_t rc;
int slen;
- unsigned elen = 0;
+ unsigned elen;
BusChild *kid;
SCLPEvent *event;
SCLPEventClass *ec;
@@ -203,11 +203,11 @@ static uint16_t handle_sccb_read_events(SCLPEventFacility *ef, SCCB *sccb,
if (mask & ec->get_send_mask()) {
if (ec->read_event_data(event, event_buf, &slen)) {
+ elen = be16_to_cpu(event_buf->length);
+ event_buf = (EventBufferHeader *) ((char *)event_buf + elen);
rc = SCLP_RC_NORMAL_COMPLETION;
}
}
- elen = be16_to_cpu(event_buf->length);
- event_buf = (void *) event_buf + elen;
}
if (sccb->h.control_mask[2] & SCLP_VARIABLE_LENGTH_RESPONSE) {
--
1.8.3.1
next prev parent reply other threads:[~2013-09-18 10:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 10:19 [Qemu-devel] [PATCH 00/11] sclp related fixes and sclp line mode console Christian Borntraeger
2013-09-18 10:19 ` [Qemu-devel] [PATCH 01/11] s390/sclpconsole: modify definition of input buffer Christian Borntraeger
2013-09-18 10:19 ` [Qemu-devel] [PATCH 02/11] s390/sclpconsole: Add code to support live migration for sclpconsole Christian Borntraeger
2013-09-20 3:07 ` Alexander Graf
2013-09-20 3:24 ` Anthony Liguori
2013-09-18 10:19 ` [Qemu-devel] [PATCH 03/11] s390/sclpquiesce: Add code to support live migration Christian Borntraeger
2013-09-20 3:08 ` Alexander Graf
2013-09-18 10:19 ` [Qemu-devel] [PATCH 04/11] s390/event-facility: " Christian Borntraeger
2013-09-18 10:19 ` [Qemu-devel] [PATCH 05/11] s390/sclp: add reset() functions Christian Borntraeger
2013-09-18 10:19 ` Christian Borntraeger [this message]
2013-09-18 10:19 ` [Qemu-devel] [PATCH 07/11] s390/eventfacility: Fix receive/send masks Christian Borntraeger
2013-09-18 10:19 ` [Qemu-devel] [PATCH 08/11] s390/eventfacility: remove unused event_type variable Christian Borntraeger
2013-09-18 10:19 ` [Qemu-devel] [PATCH 09/11] s390/eventfacility: allow childs to handle more than 1 event type Christian Borntraeger
2013-09-18 10:19 ` [Qemu-devel] [PATCH 10/11] s390/ebcdic: Move conversion tables to header file Christian Borntraeger
2013-09-20 3:21 ` Alexander Graf
2013-09-18 10:19 ` [Qemu-devel] [PATCH 11/11] s390/sclplmconsole: Add support for SCLP line-mode console Christian Borntraeger
2013-09-20 3:31 ` Alexander Graf
2013-09-20 3:32 ` [Qemu-devel] [PATCH 00/11] sclp related fixes and sclp line mode console Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379499572-49737-7-git-send-email-borntraeger@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=agraf@suse.de \
--cc=graalfs@linux.vnet.ibm.com \
--cc=jfrei@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=rhoppe@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).