qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, rusty@au1.ibm.com, qemu-stable@nongnu.org,
	stefanha@redhat.com
Subject: [Qemu-devel] [PATCH 1/2] blockdev: do not default cache.no-flush to true
Date: Thu, 19 Sep 2013 18:48:53 +0200	[thread overview]
Message-ID: <1379609334-20811-2-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1379609334-20811-1-git-send-email-pbonzini@redhat.com>

That's why all my VMs were so fast lately. :)

This changed in 1.6.0 by mistake in patch 29c4e2b (blockdev: Split up
'cache' option, 2013-07-18).

Cc: qemu-stable@nongnu.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 blockdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/blockdev.c b/blockdev.c
index 07dac05..76bfe30 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -443,7 +443,7 @@ static DriveInfo *blockdev_init(QemuOpts *all_opts,
     if (qemu_opt_get_bool(opts, "cache.direct", false)) {
         bdrv_flags |= BDRV_O_NOCACHE;
     }
-    if (qemu_opt_get_bool(opts, "cache.no-flush", true)) {
+    if (qemu_opt_get_bool(opts, "cache.no-flush", false)) {
         bdrv_flags |= BDRV_O_NO_FLUSH;
     }
 
-- 
1.8.3.1

  reply	other threads:[~2013-09-19 16:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-19 16:48 [Qemu-devel] [PATCH 0/2] Serious bugs in the handling of writeback caching Paolo Bonzini
2013-09-19 16:48 ` Paolo Bonzini [this message]
2013-09-19 17:33   ` [Qemu-devel] [PATCH 1/2] blockdev: do not default cache.no-flush to true Eric Blake
2013-09-19 16:48 ` [Qemu-devel] [PATCH 2/2] virtio-blk: do not relay a previous driver's WCE configuration to the current Paolo Bonzini
2013-09-19 17:42   ` Eric Blake
2013-09-20  9:54   ` Kevin Wolf
2013-09-20 10:28     ` Paolo Bonzini
2013-09-20 15:31   ` [Qemu-devel] [PATCH v2 " Paolo Bonzini
2013-09-20 17:28 ` [Qemu-devel] [PATCH 0/2] Serious bugs in the handling of writeback caching Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1379609334-20811-2-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    --cc=rusty@au1.ibm.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).