qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Bruce Rogers <brogers@suse.com>
To: qemu-devel@nongnu.org, kraxel@redhat.com
Cc: Bruce Rogers <brogers@suse.com>
Subject: [Qemu-devel] [PATCH 1/3] roms: use formal MAKE variable reference in roms Makefile
Date: Thu, 19 Sep 2013 15:00:34 -0600	[thread overview]
Message-ID: <1379624436-22845-2-git-send-email-brogers@suse.com> (raw)
In-Reply-To: <1379624436-22845-1-git-send-email-brogers@suse.com>

In order to properly support recursive make commands, convert
references of make to be $(MAKE). This will for example enable
parallel makes of each of the rom source trees covered by this
makefile.

Signed-off-by: Bruce Rogers <brogers@suse.com>
---
 roms/Makefile |   14 +++++++-------
 1 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/roms/Makefile b/roms/Makefile
index 7a228ae..6de9424 100644
--- a/roms/Makefile
+++ b/roms/Makefile
@@ -38,7 +38,7 @@ default:
 
 bios: config.seabios
 	sh configure-seabios.sh $<
-	make -C seabios out/bios.bin
+	$(MAKE) -C seabios out/bios.bin
 	cp seabios/out/bios.bin ../pc-bios/bios.bin
 	cp seabios/out/*dsdt.aml ../pc-bios/
 
@@ -46,27 +46,27 @@ seavgabios: $(patsubst %,seavgabios-%,$(vgabios_variants))
 
 seavgabios-%: config.vga.%
 	sh configure-seabios.sh $<
-	make -C seabios out/vgabios.bin
+	$(MAKE) -C seabios out/vgabios.bin
 	cp seabios/out/vgabios.bin ../pc-bios/vgabios-$*.bin
 
 lgplvgabios: $(patsubst %,lgplvgabios-%,$(vgabios_variants))
 
 lgplvgabios-%:
-	make -C vgabios vgabios-$*.bin
+	$(MAKE) -C vgabios vgabios-$*.bin
 	cp vgabios/VGABIOS-lgpl-latest.$*.bin ../pc-bios/vgabios-$*.bin
 
 pxerom: $(patsubst %,pxe-rom-%,$(pxerom_variants))
 
 pxe-rom-%: ipxe/src/config/local/general.h
-	make -C ipxe/src bin/$(VID)$(DID).rom
+	$(MAKE) -C ipxe/src bin/$(VID)$(DID).rom
 	cp ipxe/src/bin/$(VID)$(DID).rom ../pc-bios/pxe-$*.rom
 
 efirom: $(patsubst %,efi-rom-%,$(pxerom_variants))
 
 efi-rom-%: ipxe/src/config/local/general.h
-	make -C ipxe/src bin/$(VID)$(DID).rom
-	make -C ipxe/src bin-i386-efi/$(VID)$(DID).efidrv
-	make -C ipxe/src bin-x86_64-efi/$(VID)$(DID).efidrv
+	$(MAKE) -C ipxe/src bin/$(VID)$(DID).rom
+	$(MAKE) -C ipxe/src bin-i386-efi/$(VID)$(DID).efidrv
+	$(MAKE) -C ipxe/src bin-x86_64-efi/$(VID)$(DID).efidrv
 	$(EFIROM) -f "0x$(VID)" -i "0x$(DID)" -l 0x02 \
 		-b ipxe/src/bin/$(VID)$(DID).rom \
 		-ec ipxe/src/bin-i386-efi/$(VID)$(DID).efidrv \
-- 
1.7.7

  reply	other threads:[~2013-09-19 21:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-19 21:00 [Qemu-devel] [PATCH 0/3] roms: various improvements to roms/Makefile Bruce Rogers
2013-09-19 21:00 ` Bruce Rogers [this message]
2013-09-20  0:11   ` [Qemu-devel] [PATCH 1/3] roms: use formal MAKE variable reference in roms Makefile Bruce Rogers
2013-09-20  8:53     ` Gerd Hoffmann
2013-09-19 21:00 ` [Qemu-devel] [PATCH 2/3] roms: make and install isa vgabios binary Bruce Rogers
2013-09-19 21:00 ` [Qemu-devel] [PATCH 3/3] roms: make and install sgabios binary Bruce Rogers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1379624436-22845-2-git-send-email-brogers@suse.com \
    --to=brogers@suse.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).