From: Gerd Hoffmann <kraxel@redhat.com>
To: Bruce Rogers <brogers@suse.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/3] roms: use formal MAKE variable reference in roms Makefile
Date: Fri, 20 Sep 2013 10:53:51 +0200 [thread overview]
Message-ID: <1379667231.3453.5.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <523B3E6C02000048000E414E@novprvoes0310.provo.novell.com>
On Do, 2013-09-19 at 18:11 -0600, Bruce Rogers wrote:
> >>> On 9/19/2013 at 03:00 PM, Bruce Rogers <brogers@suse.com> wrote:
> > In order to properly support recursive make commands, convert
> > references of make to be $(MAKE). This will for example enable
> > parallel makes of each of the rom source trees covered by this
> > makefile.
> >
>
> I perhaps should clarify the above statement: This patch does not
> fix parallel make issues present in this makefile, but rather just
> permits parallel flags to be passed along for the make references
> of each target, and to ensure consistent make references are
> being done.
Which is a rather pointless exercise IMO. When tackling parallel builds
fix it for real please.
cheers,
Gerd
next prev parent reply other threads:[~2013-09-20 8:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-19 21:00 [Qemu-devel] [PATCH 0/3] roms: various improvements to roms/Makefile Bruce Rogers
2013-09-19 21:00 ` [Qemu-devel] [PATCH 1/3] roms: use formal MAKE variable reference in roms Makefile Bruce Rogers
2013-09-20 0:11 ` Bruce Rogers
2013-09-20 8:53 ` Gerd Hoffmann [this message]
2013-09-19 21:00 ` [Qemu-devel] [PATCH 2/3] roms: make and install isa vgabios binary Bruce Rogers
2013-09-19 21:00 ` [Qemu-devel] [PATCH 3/3] roms: make and install sgabios binary Bruce Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379667231.3453.5.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=brogers@suse.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).