* [Qemu-devel] [PATCH] hmp: block-stream: fix typo
@ 2013-09-20 13:07 Anthony Liguori
2013-09-23 12:10 ` Stefan Hajnoczi
0 siblings, 1 reply; 2+ messages in thread
From: Anthony Liguori @ 2013-09-20 13:07 UTC (permalink / raw)
To: qemu-devel; +Cc: Anthony Liguori
Found this by enabling C++ errors. The bool and enum arguments
are mistakenly flipped.
Signed-off-by: Anthony Liguori <anthony@codemonkey.ws>
---
hmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hmp.c b/hmp.c
index 2a90295..5891507 100644
--- a/hmp.c
+++ b/hmp.c
@@ -1163,7 +1163,7 @@ void hmp_block_stream(Monitor *mon, const QDict *qdict)
qmp_block_stream(device, base != NULL, base,
qdict_haskey(qdict, "speed"), speed,
- BLOCKDEV_ON_ERROR_REPORT, true, &error);
+ true, BLOCKDEV_ON_ERROR_REPORT, &error);
hmp_handle_error(mon, &error);
}
--
1.8.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] hmp: block-stream: fix typo
2013-09-20 13:07 [Qemu-devel] [PATCH] hmp: block-stream: fix typo Anthony Liguori
@ 2013-09-23 12:10 ` Stefan Hajnoczi
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2013-09-23 12:10 UTC (permalink / raw)
To: Anthony Liguori; +Cc: Kevin Wolf, qemu-devel
On Fri, Sep 20, 2013 at 08:07:43AM -0500, Anthony Liguori wrote:
> Found this by enabling C++ errors. The bool and enum arguments
> are mistakenly flipped.
>
> Signed-off-by: Anthony Liguori <anthony@codemonkey.ws>
> ---
> hmp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hmp.c b/hmp.c
> index 2a90295..5891507 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -1163,7 +1163,7 @@ void hmp_block_stream(Monitor *mon, const QDict *qdict)
>
> qmp_block_stream(device, base != NULL, base,
> qdict_haskey(qdict, "speed"), speed,
> - BLOCKDEV_ON_ERROR_REPORT, true, &error);
> + true, BLOCKDEV_ON_ERROR_REPORT, &error);
>
> hmp_handle_error(mon, &error);
> }
> --
> 1.8.0
Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-23 12:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-20 13:07 [Qemu-devel] [PATCH] hmp: block-stream: fix typo Anthony Liguori
2013-09-23 12:10 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).