qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Hervé Poussineau" <hpoussin@reactos.org>
Subject: [Qemu-devel] [PULL 2/6] lsi: check ssid versus sdid only if ssid is valid
Date: Fri, 20 Sep 2013 17:08:31 +0200	[thread overview]
Message-ID: <1379689715-628-3-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1379689715-628-1-git-send-email-pbonzini@redhat.com>

From: Hervé Poussineau <hpoussin@reactos.org>

This prevents some (invalid) error messages on console.

Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hw/scsi/lsi53c895a.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c
index 4cc0c6a..4314efe 100644
--- a/hw/scsi/lsi53c895a.c
+++ b/hw/scsi/lsi53c895a.c
@@ -1699,8 +1699,9 @@ static void lsi_reg_writeb(LSIState *s, int offset, uint8_t val)
         s->sxfer = val;
         break;
     case 0x06: /* SDID */
-        if ((val & 0xf) != (s->ssid & 0xf))
+        if ((s->ssid & 0x80) && (val & 0xf) != (s->ssid & 0xf)) {
             BADF("Destination ID does not match SSID\n");
+        }
         s->sdid = val & 0xf;
         break;
     case 0x07: /* GPREG0 */
-- 
1.8.3.1

  parent reply	other threads:[~2013-09-20 15:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-20 15:08 [Qemu-devel] [PULL build-fix 0/6] SCSI patches for 2013-09-20 Paolo Bonzini
2013-09-20 15:08 ` [Qemu-devel] [PULL 1/6] lsi: use constant name instead of its value Paolo Bonzini
2013-09-20 15:08 ` Paolo Bonzini [this message]
2013-09-20 15:08 ` [Qemu-devel] [PULL 3/6] lsi: ignore write accesses to CTEST0 registers Paolo Bonzini
2013-09-20 15:08 ` [Qemu-devel] [PULL 4/6] lsi: remove todo Paolo Bonzini
2013-09-20 15:08 ` [Qemu-devel] [PULL 5/6] lsi: add 53C810 variant Paolo Bonzini
2013-09-20 15:08 ` [Qemu-devel] [PULL 6/6] block/iscsi: Drop iscsi_co_get_block_status for older versions of libiscsi Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1379689715-628-3-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=hpoussin@reactos.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).