From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53643) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VN2KG-00061P-Ev for qemu-devel@nongnu.org; Fri, 20 Sep 2013 11:09:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VN2K4-0007tp-JR for qemu-devel@nongnu.org; Fri, 20 Sep 2013 11:08:56 -0400 Received: from mail-ee0-x230.google.com ([2a00:1450:4013:c00::230]:41609) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VN2K4-0007tb-Cv for qemu-devel@nongnu.org; Fri, 20 Sep 2013 11:08:44 -0400 Received: by mail-ee0-f48.google.com with SMTP id l10so330498eei.21 for ; Fri, 20 Sep 2013 08:08:43 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Fri, 20 Sep 2013 17:08:31 +0200 Message-Id: <1379689715-628-3-git-send-email-pbonzini@redhat.com> In-Reply-To: <1379689715-628-1-git-send-email-pbonzini@redhat.com> References: <1379689715-628-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PULL 2/6] lsi: check ssid versus sdid only if ssid is valid List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Herv=C3=A9=20Poussineau?= From: Hervé Poussineau This prevents some (invalid) error messages on console. Signed-off-by: Hervé Poussineau Signed-off-by: Paolo Bonzini --- hw/scsi/lsi53c895a.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c index 4cc0c6a..4314efe 100644 --- a/hw/scsi/lsi53c895a.c +++ b/hw/scsi/lsi53c895a.c @@ -1699,8 +1699,9 @@ static void lsi_reg_writeb(LSIState *s, int offset, uint8_t val) s->sxfer = val; break; case 0x06: /* SDID */ - if ((val & 0xf) != (s->ssid & 0xf)) + if ((s->ssid & 0x80) && (val & 0xf) != (s->ssid & 0xf)) { BADF("Destination ID does not match SSID\n"); + } s->sdid = val & 0xf; break; case 0x07: /* GPREG0 */ -- 1.8.3.1