From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Hervé Poussineau" <hpoussin@reactos.org>
Subject: [Qemu-devel] [PULL 3/6] lsi: ignore write accesses to CTEST0 registers
Date: Fri, 20 Sep 2013 17:08:32 +0200 [thread overview]
Message-ID: <1379689715-628-4-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1379689715-628-1-git-send-email-pbonzini@redhat.com>
From: Hervé Poussineau <hpoussin@reactos.org>
53C895A datasheet says that this register is read/write, and that the value
returned on read access is dependant of DMA FIFO state. However, nothing is
said for written value.
53C810A datasheet gives more insight about this register:
"This was a general purpose read/write register in previous SYM53C8XX
family chips. Although it is still a read/write register, Symbios reserves
the right to use these bits for future 53C8XX family enhancements."
This prevents going to the default case, which prints an error message.
Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/scsi/lsi53c895a.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c
index 4314efe..89d934b 100644
--- a/hw/scsi/lsi53c895a.c
+++ b/hw/scsi/lsi53c895a.c
@@ -1743,6 +1743,9 @@ static void lsi_reg_writeb(LSIState *s, int offset, uint8_t val)
case 0x17: /* MBOX1 */
s->mbox1 = val;
break;
+ case 0x18: /* CTEST0 */
+ /* nothing to do */
+ break;
case 0x1a: /* CTEST2 */
s->ctest2 = val & LSI_CTEST2_PCICIE;
break;
--
1.8.3.1
next prev parent reply other threads:[~2013-09-20 15:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-20 15:08 [Qemu-devel] [PULL build-fix 0/6] SCSI patches for 2013-09-20 Paolo Bonzini
2013-09-20 15:08 ` [Qemu-devel] [PULL 1/6] lsi: use constant name instead of its value Paolo Bonzini
2013-09-20 15:08 ` [Qemu-devel] [PULL 2/6] lsi: check ssid versus sdid only if ssid is valid Paolo Bonzini
2013-09-20 15:08 ` Paolo Bonzini [this message]
2013-09-20 15:08 ` [Qemu-devel] [PULL 4/6] lsi: remove todo Paolo Bonzini
2013-09-20 15:08 ` [Qemu-devel] [PULL 5/6] lsi: add 53C810 variant Paolo Bonzini
2013-09-20 15:08 ` [Qemu-devel] [PULL 6/6] block/iscsi: Drop iscsi_co_get_block_status for older versions of libiscsi Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379689715-628-4-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=hpoussin@reactos.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).