From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53579) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VN2KC-0005wz-Ty for qemu-devel@nongnu.org; Fri, 20 Sep 2013 11:08:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VN2K7-0007uX-BP for qemu-devel@nongnu.org; Fri, 20 Sep 2013 11:08:52 -0400 Received: from mail-ea0-x22f.google.com ([2a00:1450:4013:c01::22f]:51304) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VN2K6-0007uG-Gy for qemu-devel@nongnu.org; Fri, 20 Sep 2013 11:08:47 -0400 Received: by mail-ea0-f175.google.com with SMTP id m14so329814eaj.20 for ; Fri, 20 Sep 2013 08:08:45 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Fri, 20 Sep 2013 17:08:32 +0200 Message-Id: <1379689715-628-4-git-send-email-pbonzini@redhat.com> In-Reply-To: <1379689715-628-1-git-send-email-pbonzini@redhat.com> References: <1379689715-628-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PULL 3/6] lsi: ignore write accesses to CTEST0 registers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Herv=C3=A9=20Poussineau?= From: Hervé Poussineau 53C895A datasheet says that this register is read/write, and that the value returned on read access is dependant of DMA FIFO state. However, nothing is said for written value. 53C810A datasheet gives more insight about this register: "This was a general purpose read/write register in previous SYM53C8XX family chips. Although it is still a read/write register, Symbios reserves the right to use these bits for future 53C8XX family enhancements." This prevents going to the default case, which prints an error message. Signed-off-by: Hervé Poussineau Signed-off-by: Paolo Bonzini --- hw/scsi/lsi53c895a.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c index 4314efe..89d934b 100644 --- a/hw/scsi/lsi53c895a.c +++ b/hw/scsi/lsi53c895a.c @@ -1743,6 +1743,9 @@ static void lsi_reg_writeb(LSIState *s, int offset, uint8_t val) case 0x17: /* MBOX1 */ s->mbox1 = val; break; + case 0x18: /* CTEST0 */ + /* nothing to do */ + break; case 0x1a: /* CTEST2 */ s->ctest2 = val & LSI_CTEST2_PCICIE; break; -- 1.8.3.1