qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Jan Kiszka <jan.kiszka@siemens.com>, qemu-stable@nongnu.org
Subject: [Qemu-devel] [PULL 07/13] kvmvapic: Enter inactive state on hardware reset
Date: Fri, 20 Sep 2013 18:24:46 +0200	[thread overview]
Message-ID: <1379694292-1601-8-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1379694292-1601-1-git-send-email-pbonzini@redhat.com>

From: Jan Kiszka <jan.kiszka@siemens.com>

ROM layout may change after reset of devices are hotplugged, so we have
to pick up the physical address again when the ROM is initialized. This
is best achieved by resetting the state to INACTIVE.

CC: qemu-stable@nongnu.org
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hw/i386/kvmvapic.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/hw/i386/kvmvapic.c b/hw/i386/kvmvapic.c
index c66fbf2..e4cea34 100644
--- a/hw/i386/kvmvapic.c
+++ b/hw/i386/kvmvapic.c
@@ -510,9 +510,7 @@ static void vapic_reset(DeviceState *dev)
 {
     VAPICROMState *s = VAPIC(dev);
 
-    if (s->state == VAPIC_ACTIVE) {
-        s->state = VAPIC_STANDBY;
-    }
+    s->state = VAPIC_INACTIVE;
     vapic_enable_tpr_reporting(false);
 }
 
-- 
1.8.3.1

  parent reply	other threads:[~2013-09-20 16:25 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-20 16:24 [Qemu-devel] [PULL 00/13] KVM patches for 2013-09-20 Paolo Bonzini
2013-09-20 16:24 ` [Qemu-devel] [PULL 01/13] exec: always use MADV_DONTFORK Paolo Bonzini
2013-09-20 16:24 ` [Qemu-devel] [PULL 02/13] cpu: Move cpu state syncs up into cpu_dump_state() Paolo Bonzini
2013-09-20 16:24 ` [Qemu-devel] [PULL 03/13] kvm: warn if num cpus is greater than num recommended Paolo Bonzini
2013-09-20 16:24 ` [Qemu-devel] [PULL 04/13] fix steal time MSR vmsd callback to proper opaque type Paolo Bonzini
2013-09-20 16:24 ` [Qemu-devel] [PULL 05/13] kvm irqfd: support direct msimessage to irq translation Paolo Bonzini
2013-09-20 16:24 ` [Qemu-devel] [PULL 06/13] kvmvapic: Catch invalid ROM size Paolo Bonzini
2013-09-20 16:24 ` Paolo Bonzini [this message]
2013-09-20 16:24 ` [Qemu-devel] [PULL 08/13] kvmvapic: Clear also physical ROM address when entering INACTIVE state Paolo Bonzini
2013-09-20 16:24 ` [Qemu-devel] [PULL 09/13] kvm: fix traces to use %x instead of %d Paolo Bonzini
2013-09-20 16:24 ` [Qemu-devel] [PULL 10/13] linux-headers: update to 3.11 Paolo Bonzini
2013-09-20 16:24 ` [Qemu-devel] [PULL 11/13] target-i386: forward CPUID cache leaves when -cpu host is used Paolo Bonzini
2013-11-18 15:23   ` Peter Lieven
2013-11-18 15:37     ` Peter Lieven
2013-11-18 16:11       ` Paolo Bonzini
2013-11-18 19:53         ` Peter Lieven
2013-11-19 10:50           ` Paolo Bonzini
2013-11-19 11:35             ` Peter Lieven
2013-11-19 11:37               ` Paolo Bonzini
2013-11-19 11:42                 ` Peter Lieven
2013-11-19 10:25         ` Peter Lieven
2013-11-19 10:47           ` Paolo Bonzini
2013-11-19 11:07             ` Peter Lieven
2013-11-19 12:03             ` Peter Lieven
2013-11-19 12:08               ` Peter Lieven
2013-11-19 12:14               ` Paolo Bonzini
2013-11-19 12:32                 ` Peter Lieven
2013-11-19 13:21                   ` Paolo Bonzini
2013-11-19 14:11                     ` Peter Lieven
2013-11-19 14:14                       ` Paolo Bonzini
2013-11-19 14:17                         ` Peter Lieven
2013-11-19 14:19                           ` Paolo Bonzini
2013-11-19 14:46                             ` Peter Lieven
2013-11-19 14:57                               ` Paolo Bonzini
2013-11-19 15:05                                 ` Peter Lieven
2013-11-19 15:11                                   ` Paolo Bonzini
2013-09-20 16:24 ` [Qemu-devel] [PULL 12/13] linux-headers: update to 3.12-rc1 Paolo Bonzini
2013-09-20 16:24 ` [Qemu-devel] [PULL 13/13] target-i386: add feature kvm_pv_unhalt Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1379694292-1601-8-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).