From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60106) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VN4j9-0003YR-Fk for qemu-devel@nongnu.org; Fri, 20 Sep 2013 13:42:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VN4j4-0005Es-Ao for qemu-devel@nongnu.org; Fri, 20 Sep 2013 13:42:47 -0400 From: Stefan Hajnoczi Date: Fri, 20 Sep 2013 19:42:10 +0200 Message-Id: <1379698931-946-11-git-send-email-stefanha@redhat.com> In-Reply-To: <1379698931-946-1-git-send-email-stefanha@redhat.com> References: <1379698931-946-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PULL 10/11] blockdev: do not default cache.no-flush to true List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Stefan Hajnoczi , qemu-stable@nongnu.org, Anthony Liguori From: Paolo Bonzini That's why all my VMs were so fast lately. :) This changed in 1.6.0 by mistake in patch 29c4e2b (blockdev: Split up 'cache' option, 2013-07-18). Cc: qemu-stable@nongnu.org Signed-off-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- blockdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/blockdev.c b/blockdev.c index 80605a2..8aa66a9 100644 --- a/blockdev.c +++ b/blockdev.c @@ -443,7 +443,7 @@ static DriveInfo *blockdev_init(QemuOpts *all_opts, if (qemu_opt_get_bool(opts, "cache.direct", false)) { bdrv_flags |= BDRV_O_NOCACHE; } - if (qemu_opt_get_bool(opts, "cache.no-flush", true)) { + if (qemu_opt_get_bool(opts, "cache.no-flush", false)) { bdrv_flags |= BDRV_O_NO_FLUSH; } -- 1.8.3.1