From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60082) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VN4j5-0003QX-HF for qemu-devel@nongnu.org; Fri, 20 Sep 2013 13:42:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VN4j0-0005Dz-9A for qemu-devel@nongnu.org; Fri, 20 Sep 2013 13:42:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42861) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VN4j0-0005Dk-0D for qemu-devel@nongnu.org; Fri, 20 Sep 2013 13:42:38 -0400 From: Stefan Hajnoczi Date: Fri, 20 Sep 2013 19:42:07 +0200 Message-Id: <1379698931-946-8-git-send-email-stefanha@redhat.com> In-Reply-To: <1379698931-946-1-git-send-email-stefanha@redhat.com> References: <1379698931-946-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PULL 07/11] coroutine: fix /perf/nesting coroutine benchmark List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gabriel Kerneis , Stefan Hajnoczi , Anthony Liguori From: Gabriel Kerneis The /perf/nesting benchmark is broken because the counters are not reset after each iteration. Therefore, nesting is done only on the first iteration, and skipped on every other. This patch fixes the issue, and reduces the number of iterations to make it possible to run the benchmark in a reasonable amount of time. Signed-off-by: Gabriel Kerneis Signed-off-by: Stefan Hajnoczi --- tests/test-coroutine.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/test-coroutine.c b/tests/test-coroutine.c index 2792191..15a885e 100644 --- a/tests/test-coroutine.c +++ b/tests/test-coroutine.c @@ -182,17 +182,17 @@ static void perf_nesting(void) unsigned int i, maxcycles, maxnesting; double duration; - maxcycles = 100000000; + maxcycles = 10000; maxnesting = 1000; Coroutine *root; - NestData nd = { - .n_enter = 0, - .n_return = 0, - .max = maxnesting, - }; g_test_timer_start(); for (i = 0; i < maxcycles; i++) { + NestData nd = { + .n_enter = 0, + .n_return = 0, + .max = maxnesting, + }; root = qemu_coroutine_create(nest); qemu_coroutine_enter(root, &nd); } -- 1.8.3.1