qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: agraf@suse.de
Subject: [Qemu-devel] [PATCH 04/10] target-s390: Raise OPERATION exception for disabled insns
Date: Mon, 23 Sep 2013 07:04:39 -0700	[thread overview]
Message-ID: <1379945085-29086-5-git-send-email-rth@twiddle.net> (raw)
In-Reply-To: <1379945085-29086-1-git-send-email-rth@twiddle.net>

Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 target-s390x/translate.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/target-s390x/translate.c b/target-s390x/translate.c
index 5aac7b0..c8bbedb 100644
--- a/target-s390x/translate.c
+++ b/target-s390x/translate.c
@@ -53,6 +53,7 @@ struct DisasContext {
     const DisasInsn *insn;
     DisasFields *fields;
     uint64_t pc, next_pc;
+    uint64_t fac0;
     enum cc_op cc_op;
     bool singlestep_enabled;
 };
@@ -4651,6 +4652,16 @@ static ExitStatus translate_one(CPUS390XState *env, DisasContext *s)
         return EXIT_NORETURN;
     }
 
+    /* Check for operation exceptions for insns that have been disabled.
+       Do this by shifting the facilities word0 up by the IBM big-endian
+       bit numbering, leaving the bit to be tested in the sign bit.
+       Note that TCG does not currently support any facilities in word1.  */
+    assert(insn->fac < 64);
+    if ((int64_t)(s->fac0 << insn->fac) >= 0) {
+        gen_program_exception(s, PGM_OPERATION);
+        return EXIT_NORETURN;
+    }
+
     /* Check for insn specification exceptions.  */
     if (insn->spec) {
         int spec = insn->spec, excp = 0, r;
@@ -4769,6 +4780,7 @@ static inline void gen_intermediate_code_internal(S390CPU *cpu,
     dc.tb = tb;
     dc.pc = pc_start;
     dc.cc_op = CC_OP_DYNAMIC;
+    dc.fac0 = env->facilities[0];
     do_debug = dc.singlestep_enabled = cs->singlestep_enabled;
 
     gen_opc_end = tcg_ctx.gen_opc_buf + OPC_MAX_SIZE;
-- 
1.8.1.4

  parent reply	other threads:[~2013-09-23 14:05 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-23 14:04 [Qemu-devel] [PATCH 0/9] target-s390 tcg improvements Richard Henderson
2013-09-23 14:04 ` [Qemu-devel] [PATCH 01/10] target-s390: Move facilities bits to env Richard Henderson
2013-09-30 18:03   ` Alexander Graf
2013-09-30 19:15     ` Richard Henderson
2013-10-01 15:48       ` Alexander Graf
2013-10-01 15:52         ` Richard Henderson
2013-10-01 15:54           ` Alexander Graf
2013-10-01 15:56             ` Richard Henderson
2013-09-23 14:04 ` [Qemu-devel] [PATCH 02/10] target-s390: Implement STFLE Richard Henderson
2013-09-23 14:04 ` [Qemu-devel] [PATCH 03/10] target-s390: Add facilities bits and sets Richard Henderson
2013-09-23 14:04 ` Richard Henderson [this message]
2013-09-23 14:04 ` [Qemu-devel] [PATCH 05/10] target-s390: Implement SAM31 and SAM64 Richard Henderson
2013-09-23 14:04 ` [Qemu-devel] [PATCH 06/10] target-s390: Implement EPSW Richard Henderson
2013-09-23 14:04 ` [Qemu-devel] [PATCH 07/10] target-s390: Fix STIDP Richard Henderson
2013-09-30 18:13   ` Alexander Graf
2013-09-30 19:48     ` Richard Henderson
2013-10-01 15:52       ` Alexander Graf
2013-10-01 15:54         ` Richard Henderson
2013-09-23 14:04 ` [Qemu-devel] [PATCH 08/10] target-s390: Fix STURA Richard Henderson
2013-09-23 14:04 ` [Qemu-devel] [PATCH 09/10] target-s390: Implement LURA, LURAG, STURG Richard Henderson
2013-09-23 14:04 ` [Qemu-devel] [PATCH 10/10] target-s390: Implement ECAG Richard Henderson
2013-09-30 18:19 ` [Qemu-devel] [PATCH 0/9] target-s390 tcg improvements Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1379945085-29086-5-git-send-email-rth@twiddle.net \
    --to=rth@twiddle.net \
    --cc=agraf@suse.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).