* [Qemu-devel] [PATCH] qemu-iotests: Do not execute 052 with -nocache
@ 2013-09-23 14:38 Max Reitz
2013-09-24 11:32 ` Stefan Hajnoczi
2013-09-24 14:58 ` Kevin Wolf
0 siblings, 2 replies; 3+ messages in thread
From: Max Reitz @ 2013-09-23 14:38 UTC (permalink / raw)
To: qemu-devel; +Cc: Kevin Wolf, Stefan Hajnoczi, Max Reitz
Test 052 uses qemu-io -s which will result in bdrv_open trying to create
a temporary snapshot file in /tmp. However, since O_DIRECT and tmpfs
do not work well together, disable this test for -nocache.
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
tests/qemu-iotests/052 | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/qemu-iotests/052 b/tests/qemu-iotests/052
index 14a5126..49810cb 100755
--- a/tests/qemu-iotests/052
+++ b/tests/qemu-iotests/052
@@ -41,6 +41,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
_supported_fmt generic
_supported_proto generic
_supported_os Linux
+_unsupported_qemu_io_options --nocache
size=128M
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu-iotests: Do not execute 052 with -nocache
2013-09-23 14:38 [Qemu-devel] [PATCH] qemu-iotests: Do not execute 052 with -nocache Max Reitz
@ 2013-09-24 11:32 ` Stefan Hajnoczi
2013-09-24 14:58 ` Kevin Wolf
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2013-09-24 11:32 UTC (permalink / raw)
To: Max Reitz; +Cc: Kevin Wolf, qemu-devel
On Mon, Sep 23, 2013 at 04:38:33PM +0200, Max Reitz wrote:
> Test 052 uses qemu-io -s which will result in bdrv_open trying to create
> a temporary snapshot file in /tmp. However, since O_DIRECT and tmpfs
> do not work well together, disable this test for -nocache.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> tests/qemu-iotests/052 | 1 +
> 1 file changed, 1 insertion(+)
Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu-iotests: Do not execute 052 with -nocache
2013-09-23 14:38 [Qemu-devel] [PATCH] qemu-iotests: Do not execute 052 with -nocache Max Reitz
2013-09-24 11:32 ` Stefan Hajnoczi
@ 2013-09-24 14:58 ` Kevin Wolf
1 sibling, 0 replies; 3+ messages in thread
From: Kevin Wolf @ 2013-09-24 14:58 UTC (permalink / raw)
To: Max Reitz; +Cc: qemu-devel, Stefan Hajnoczi
Am 23.09.2013 um 16:38 hat Max Reitz geschrieben:
> Test 052 uses qemu-io -s which will result in bdrv_open trying to create
> a temporary snapshot file in /tmp. However, since O_DIRECT and tmpfs
> do not work well together, disable this test for -nocache.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
Thanks, applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-24 14:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-23 14:38 [Qemu-devel] [PATCH] qemu-iotests: Do not execute 052 with -nocache Max Reitz
2013-09-24 11:32 ` Stefan Hajnoczi
2013-09-24 14:58 ` Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).