* [Qemu-devel] [PATCH] spapr: increase temporary fdt buffer size
@ 2013-09-24 5:59 Alexey Kardashevskiy
2013-09-24 10:05 ` mike
2013-09-25 15:00 ` Alexander Graf
0 siblings, 2 replies; 4+ messages in thread
From: Alexey Kardashevskiy @ 2013-09-24 5:59 UTC (permalink / raw)
To: qemu-devel; +Cc: Alexey Kardashevskiy, qemu-ppc, Alexander Graf, David Gibson
At the moment the size of the buffer is set to 64K which is
enough for approximately 150 VCPUs which is not the limit.
This increases the buffer up to 256K which allows having
a tree for approximately 600 VCPUs which is way beyond the real
number we need.
As only the real size of the tree is copied to the guest, there
will be no impact on existing configurations.
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
hw/ppc/spapr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 1bb76f1..063fe63 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -62,7 +62,7 @@
*
* We load our kernel at 4M, leaving space for SLOF initial image
*/
-#define FDT_MAX_SIZE 0x10000
+#define FDT_MAX_SIZE 0x40000
#define RTAS_MAX_SIZE 0x10000
#define FW_MAX_SIZE 0x400000
#define FW_FILE_NAME "slof.bin"
--
1.8.4.rc4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] spapr: increase temporary fdt buffer size
2013-09-24 5:59 [Qemu-devel] [PATCH] spapr: increase temporary fdt buffer size Alexey Kardashevskiy
@ 2013-09-24 10:05 ` mike
2013-09-25 14:55 ` Alexander Graf
2013-09-25 15:00 ` Alexander Graf
1 sibling, 1 reply; 4+ messages in thread
From: mike @ 2013-09-24 10:05 UTC (permalink / raw)
To: Alexey Kardashevskiy; +Cc: David Gibson, qemu-ppc, qemu-devel, Alexander Graf
On 09/24/2013 01:59 PM, Alexey Kardashevskiy wrote:
> At the moment the size of the buffer is set to 64K which is
> enough for approximately 150 VCPUs which is not the limit.
>
> This increases the buffer up to 256K which allows having
> a tree for approximately 600 VCPUs which is way beyond the real
> number we need.
>
> As only the real size of the tree is copied to the guest, there
> will be no impact on existing configurations.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
> hw/ppc/spapr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index 1bb76f1..063fe63 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -62,7 +62,7 @@
> *
> * We load our kernel at 4M, leaving space for SLOF initial image
> */
> -#define FDT_MAX_SIZE 0x10000
> +#define FDT_MAX_SIZE 0x40000
> #define RTAS_MAX_SIZE 0x10000
> #define FW_MAX_SIZE 0x400000
> #define FW_FILE_NAME "slof.bin"
Signed-off-by: Mike Qiu <qiudayu@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] spapr: increase temporary fdt buffer size
2013-09-24 10:05 ` mike
@ 2013-09-25 14:55 ` Alexander Graf
0 siblings, 0 replies; 4+ messages in thread
From: Alexander Graf @ 2013-09-25 14:55 UTC (permalink / raw)
To: mike; +Cc: Alexey Kardashevskiy, qemu-ppc, qemu-devel, David Gibson
On 24.09.2013, at 12:05, mike wrote:
> On 09/24/2013 01:59 PM, Alexey Kardashevskiy wrote:
>> At the moment the size of the buffer is set to 64K which is
>> enough for approximately 150 VCPUs which is not the limit.
>>
>> This increases the buffer up to 256K which allows having
>> a tree for approximately 600 VCPUs which is way beyond the real
>> number we need.
>>
>> As only the real size of the tree is copied to the guest, there
>> will be no impact on existing configurations.
>>
>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>> ---
>> hw/ppc/spapr.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
>> index 1bb76f1..063fe63 100644
>> --- a/hw/ppc/spapr.c
>> +++ b/hw/ppc/spapr.c
>> @@ -62,7 +62,7 @@
>> *
>> * We load our kernel at 4M, leaving space for SLOF initial image
>> */
>> -#define FDT_MAX_SIZE 0x10000
>> +#define FDT_MAX_SIZE 0x40000
>> #define RTAS_MAX_SIZE 0x10000
>> #define FW_MAX_SIZE 0x400000
>> #define FW_FILE_NAME "slof.bin"
> Signed-off-by: Mike Qiu <qiudayu@linux.vnet.ibm.com>
Signed-off-by is supposed to mean "this patch went through my hands". So are you trying to say that you wrote this patch? Or that you think it does "the right thing" in which case it should be "Acked-by" or "Reviewed-by":
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches?id=f6f94e2ab1b33f0082ac22d71f66385a60d8157f#n297
Alex
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] spapr: increase temporary fdt buffer size
2013-09-24 5:59 [Qemu-devel] [PATCH] spapr: increase temporary fdt buffer size Alexey Kardashevskiy
2013-09-24 10:05 ` mike
@ 2013-09-25 15:00 ` Alexander Graf
1 sibling, 0 replies; 4+ messages in thread
From: Alexander Graf @ 2013-09-25 15:00 UTC (permalink / raw)
To: Alexey Kardashevskiy; +Cc: qemu-ppc, qemu-devel, David Gibson
On 24.09.2013, at 07:59, Alexey Kardashevskiy wrote:
> At the moment the size of the buffer is set to 64K which is
> enough for approximately 150 VCPUs which is not the limit.
>
> This increases the buffer up to 256K which allows having
> a tree for approximately 600 VCPUs which is way beyond the real
> number we need.
>
> As only the real size of the tree is copied to the guest, there
> will be no impact on existing configurations.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Thanks, applied to ppc-next.
Alex
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-09-25 15:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-24 5:59 [Qemu-devel] [PATCH] spapr: increase temporary fdt buffer size Alexey Kardashevskiy
2013-09-24 10:05 ` mike
2013-09-25 14:55 ` Alexander Graf
2013-09-25 15:00 ` Alexander Graf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).