qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel <qemu-devel@nongnu.org>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Alexander Graf <agraf@suse.de>,
	Richard Henderson <rth@twiddle.net>
Subject: [Qemu-devel] [PULL 13/17] s390/eventfacility: Fix receive/send masks
Date: Tue, 24 Sep 2013 09:27:47 +0200	[thread overview]
Message-ID: <1380007671-18976-14-git-send-email-borntraeger@de.ibm.com> (raw)
In-Reply-To: <1380007671-18976-1-git-send-email-borntraeger@de.ibm.com>

Currently we announce interchanged receive/send masks. This did not
trigger a bug, since the sclp console has the same masks for
send/receive and the Linux guest does not check the sclp mask for simple
events like quiesce. With other event users like the sclp line mode
console, we will have different send/receive bits. Fix it.

Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Reviewed-by: Alexander Graf <agraf@suse.de>
---
 include/hw/s390x/event-facility.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/hw/s390x/event-facility.h b/include/hw/s390x/event-facility.h
index 791ab2a..727ef4f 100644
--- a/include/hw/s390x/event-facility.h
+++ b/include/hw/s390x/event-facility.h
@@ -43,8 +43,8 @@ typedef struct WriteEventMask {
     uint16_t mask_length;
     uint32_t cp_receive_mask;
     uint32_t cp_send_mask;
-    uint32_t send_mask;
     uint32_t receive_mask;
+    uint32_t send_mask;
 } QEMU_PACKED WriteEventMask;
 
 typedef struct EventBufferHeader {
-- 
1.8.3.1

  parent reply	other threads:[~2013-09-24  7:27 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-24  7:27 [Qemu-devel] [PULL 00/17] s390 patches Christian Borntraeger
2013-09-24  7:27 ` [Qemu-devel] [PULL 01/17] s390/kvm: Add check for priviledged SCLP handler Christian Borntraeger
2013-09-24  7:27 ` [Qemu-devel] [PULL 02/17] s390/dump: zero out padding bytes in notes sections Christian Borntraeger
2013-09-24  7:27 ` [Qemu-devel] [PULL 03/17] s390/ipl: Fix waiting for virtio processing Christian Borntraeger
2013-09-24  7:27 ` [Qemu-devel] [PULL 04/17] s390/ipl: Update the s390-ccw.img rom Christian Borntraeger
2013-09-24  7:27 ` [Qemu-devel] [PULL 05/17] s390/cpu: Make setcc() function available to other files Christian Borntraeger
2013-09-24  7:27 ` [Qemu-devel] [PULL 06/17] s390/ioinst: Moved the CC setting to the IO instruction handlers Christian Borntraeger
2013-09-24  7:27 ` [Qemu-devel] [PULL 07/17] s390/kexec: Implement diag308 subcode 0 Christian Borntraeger
2013-09-24  7:27 ` [Qemu-devel] [PULL 08/17] s390/sclpconsole: modify definition of input buffer Christian Borntraeger
2013-09-24  7:27 ` [Qemu-devel] [PULL 09/17] s390/sclpconsole: Add code to support live migration for sclpconsole Christian Borntraeger
2013-09-24  7:27 ` [Qemu-devel] [PULL 10/17] s390/sclpquiesce: Add code to support live migration Christian Borntraeger
2013-09-24  7:27 ` [Qemu-devel] [PULL 11/17] s390/sclp: add reset() functions Christian Borntraeger
2013-09-24  7:27 ` [Qemu-devel] [PULL 12/17] s390/eventfacility: fix multiple Read Event Data sources Christian Borntraeger
2013-09-24  7:27 ` Christian Borntraeger [this message]
2013-09-24  7:27 ` [Qemu-devel] [PULL 14/17] s390/eventfacility: remove unused event_type variable Christian Borntraeger
2013-09-24  7:27 ` [Qemu-devel] [PULL 15/17] s390/eventfacility: allow childs to handle more than 1 event type Christian Borntraeger
2013-09-24  7:27 ` [Qemu-devel] [PULL 16/17] s390/ebcdic: Move conversion tables to header file Christian Borntraeger
2013-09-24  7:27 ` [Qemu-devel] [PULL 17/17] s390/sclplmconsole: Add support for SCLP line-mode console Christian Borntraeger
2013-09-25 15:07 ` [Qemu-devel] [PULL 00/17] s390 patches Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1380007671-18976-14-git-send-email-borntraeger@de.ibm.com \
    --to=borntraeger@de.ibm.com \
    --cc=agraf@suse.de \
    --cc=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).