qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Lieven <pl@kamp.de>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, ronniesahlberg@gmail.com,
	Peter Lieven <pl@kamp.de>,
	stefanha@redhat.com, anthony@codemonkey.ws, pbonzini@redhat.com
Subject: [Qemu-devel] [PATCHv3 04/20] block: introduce bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes
Date: Tue, 24 Sep 2013 15:34:58 +0200	[thread overview]
Message-ID: <1380029714-5239-5-git-send-email-pl@kamp.de> (raw)
In-Reply-To: <1380029714-5239-1-git-send-email-pl@kamp.de>

Signed-off-by: Peter Lieven <pl@kamp.de>
---
 block.c                   |   29 +++++++++++++++++++++++++++++
 include/block/block.h     |    2 ++
 include/block/block_int.h |   13 +++++++++++++
 3 files changed, 44 insertions(+)

diff --git a/block.c b/block.c
index e7bf6af..ac35cb5 100644
--- a/block.c
+++ b/block.c
@@ -3101,6 +3101,35 @@ int bdrv_has_zero_init(BlockDriverState *bs)
     return 0;
 }
 
+bool bdrv_has_discard_zeroes(BlockDriverState *bs)
+{
+    assert(bs->drv);
+
+    if (bs->backing_hd) {
+        return false;
+    }
+    if (bs->drv->bdrv_has_discard_zeroes) {
+        return bs->drv->bdrv_has_discard_zeroes(bs);
+    }
+
+    return false;
+}
+
+bool bdrv_has_discard_write_zeroes(BlockDriverState *bs)
+{
+    assert(bs->drv);
+
+    if (bs->backing_hd || !(bs->open_flags & BDRV_O_UNMAP)) {
+        return false;
+    }
+
+    if (bs->drv->bdrv_has_discard_write_zeroes) {
+        return bs->drv->bdrv_has_discard_write_zeroes(bs);
+    }
+
+    return false;
+}
+
 typedef struct BdrvCoGetBlockStatusData {
     BlockDriverState *bs;
     BlockDriverState *base;
diff --git a/include/block/block.h b/include/block/block.h
index b72c81a..2de226f 100644
--- a/include/block/block.h
+++ b/include/block/block.h
@@ -310,6 +310,8 @@ int bdrv_discard(BlockDriverState *bs, int64_t sector_num, int nb_sectors);
 int bdrv_co_discard(BlockDriverState *bs, int64_t sector_num, int nb_sectors);
 int bdrv_has_zero_init_1(BlockDriverState *bs);
 int bdrv_has_zero_init(BlockDriverState *bs);
+bool bdrv_has_discard_zeroes(BlockDriverState *bs);
+bool bdrv_has_discard_write_zeroes(BlockDriverState *bs);
 int64_t bdrv_get_block_status(BlockDriverState *bs, int64_t sector_num,
                               int nb_sectors, int *pnum);
 int bdrv_is_allocated(BlockDriverState *bs, int64_t sector_num, int nb_sectors,
diff --git a/include/block/block_int.h b/include/block/block_int.h
index 56e1994..cf78c3f 100644
--- a/include/block/block_int.h
+++ b/include/block/block_int.h
@@ -211,6 +211,19 @@ struct BlockDriver {
      */
     int (*bdrv_has_zero_init)(BlockDriverState *bs);
 
+    /*
+     * Returns true if discarded blocks read back as zeroes.
+     */
+    bool (*bdrv_has_discard_zeroes)(BlockDriverState *bs);
+
+    /*
+     * Returns true if the driver can optimize writing zeroes by discarding
+     * sectors. It is additionally required that the block device is
+     * opened with BDRV_O_UNMAP and the that write zeroes request carries
+     * the BDRV_REQ_MAY_UNMAP flag for this to work.
+     */
+    bool (*bdrv_has_discard_write_zeroes)(BlockDriverState *bs);
+
     QLIST_ENTRY(BlockDriver) list;
 };
 
-- 
1.7.9.5

  parent reply	other threads:[~2013-09-24 13:36 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-24 13:34 [Qemu-devel] [PATCHv3 00/20] block: logical block provisioning enhancements Peter Lieven
2013-09-24 13:34 ` [Qemu-devel] [PATCHv3 01/20] block: make BdrvRequestFlags public Peter Lieven
2013-09-24 13:34 ` [Qemu-devel] [PATCHv3 02/20] block: add flags to bdrv_*_write_zeroes Peter Lieven
2013-10-02 15:32   ` Eric Blake
2013-09-24 13:34 ` [Qemu-devel] [PATCHv3 03/20] block: introduce BDRV_REQ_MAY_UNMAP request flag Peter Lieven
2013-09-24 13:34 ` Peter Lieven [this message]
2013-10-02 15:41   ` [Qemu-devel] [PATCHv3 04/20] block: introduce bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes Eric Blake
2013-09-24 13:34 ` [Qemu-devel] [PATCHv3 05/20] block/raw: add " Peter Lieven
2013-10-02 15:43   ` Eric Blake
2013-09-24 13:35 ` [Qemu-devel] [PATCHv3 06/20] block: add BlockLimits structure to BlockDriverState Peter Lieven
2013-10-02 15:53   ` Eric Blake
2013-10-07  8:10     ` Stefan Hajnoczi
2013-09-24 13:35 ` [Qemu-devel] [PATCHv3 07/20] block: honour BlockLimits in bdrv_co_do_write_zeroes Peter Lieven
2013-10-02 16:37   ` Eric Blake
2013-09-24 13:35 ` [Qemu-devel] [PATCHv3 08/20] block: honour BlockLimits in bdrv_co_discard Peter Lieven
2013-10-02 16:41   ` Eric Blake
2013-10-07  8:29   ` Stefan Hajnoczi
2013-10-07  8:36     ` Peter Lieven
2013-09-24 13:35 ` [Qemu-devel] [PATCHv3 09/20] iscsi: simplify iscsi_co_discard Peter Lieven
2013-09-24 13:35 ` [Qemu-devel] [PATCHv3 10/20] iscsi: set limits in BlockDriverState Peter Lieven
2013-10-02 16:43   ` Eric Blake
2013-09-24 13:35 ` [Qemu-devel] [PATCHv3 11/20] iscsi: add bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes Peter Lieven
2013-10-02 16:45   ` Eric Blake
2013-09-24 13:35 ` [Qemu-devel] [PATCHv3 12/20] iscsi: add bdrv_co_write_zeroes Peter Lieven
2013-09-24 13:35 ` [Qemu-devel] [PATCHv3 13/20] block: introduce bdrv_zeroize Peter Lieven
2013-10-02 16:51   ` Eric Blake
2013-10-07  8:34   ` Stefan Hajnoczi
2013-10-07  8:39     ` Peter Lieven
2013-09-24 13:35 ` [Qemu-devel] [PATCHv3 14/20] block/get_block_status: set *pnum = 0 on error Peter Lieven
2013-09-24 13:35 ` [Qemu-devel] [PATCHv3 15/20] block/get_block_status: avoid segfault if there is no backing_hd Peter Lieven
2013-09-24 13:35 ` [Qemu-devel] [PATCHv3 16/20] block/get_block_status: avoid redundant callouts on raw devices Peter Lieven
2013-09-24 13:35 ` [Qemu-devel] [PATCHv3 17/20] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks Peter Lieven
2013-09-24 13:35 ` [Qemu-devel] [PATCHv3 18/20] qemu-img: add support for fully allocated images Peter Lieven
2013-10-02 17:01   ` Eric Blake
2013-09-24 13:35 ` [Qemu-devel] [PATCHv3 19/20] qemu-img: conditionally zero out target on convert Peter Lieven
2013-09-24 13:35 ` [Qemu-devel] [PATCHv3 20/20] block/raw: copy BlockLimits on raw_open Peter Lieven
2013-10-02 17:11   ` Eric Blake
2013-10-07  8:38     ` Stefan Hajnoczi
2013-10-07  8:40       ` Peter Lieven
2013-10-07  8:42 ` [Qemu-devel] [PATCHv3 00/20] block: logical block provisioning enhancements Stefan Hajnoczi
2013-10-07  8:47   ` Peter Lieven
2013-10-07  9:42   ` Paolo Bonzini
2013-10-08  7:02     ` Stefan Hajnoczi
2013-10-08  8:01       ` Peter Lieven
2013-10-08  8:59         ` Stefan Hajnoczi
2013-10-08  9:12           ` Peter Lieven
2013-10-08  9:26             ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1380029714-5239-5-git-send-email-pl@kamp.de \
    --to=pl@kamp.de \
    --cc=anthony@codemonkey.ws \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=ronniesahlberg@gmail.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).