From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47724) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOoWe-0007gB-0n for qemu-devel@nongnu.org; Wed, 25 Sep 2013 08:49:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VOoWY-0005OS-1O for qemu-devel@nongnu.org; Wed, 25 Sep 2013 08:49:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57816) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOoWX-0005OO-Pt for qemu-devel@nongnu.org; Wed, 25 Sep 2013 08:48:57 -0400 Message-ID: <1380113332.3625.45.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Wed, 25 Sep 2013 14:48:52 +0200 In-Reply-To: <1380108120-18700-1-git-send-email-mst@redhat.com> References: <1380108120-18700-1-git-send-email-mst@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 00/23] qemu: generate acpi tables for the guest List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, Anthony Liguori , afaerber@suse.de On Mi, 2013-09-25 at 14:22 +0300, Michael S. Tsirkin wrote: > This code can also be found here: > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git acpi > > While this patch still uses info not available in QOM, I think it's reasonable > to merge it and then refactor as QOM properties cover more ground. Testing with coreboot (-M pc only so far, -M q35 tbd). [root@fedora ~]# cat /proc/ioports [ ... ] afe0-afe3 : ACPI GPE0_BLK b010-b015 : ACPI CPU throttle b100-b10f : 0000:00:01.3 b100-b107 : piix4_smbus e400-e43f : 0000:00:01.3 e400-e403 : ACPI PM1a_EVT_BLK e404-e405 : ACPI PM1a_CNT_BLK e408-e40b : ACPI PM_TMR "ACPI CPU throttle" looks wrong, probably hardcoded to 0xb010 instead of pmbase+0x10. Otherwise it looks good so far. cheers, Gerd