qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Michael Walle <michael@walle.cc>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, Michael Walle <michael@walle.cc>
Subject: [Qemu-devel] [PULL 06/11] milkymist-vgafb: swap pixel data in source buffer
Date: Wed, 25 Sep 2013 20:59:27 +0200	[thread overview]
Message-ID: <1380135572-25095-7-git-send-email-michael@walle.cc> (raw)
In-Reply-To: <1380135572-25095-1-git-send-email-michael@walle.cc>

In commit fc97bb5ba3e7239c0b6d24095df6784868dfebbf the lduw_raw() call was
eliminated. But we are reading from the target buffer a 16-bit value, which
is in big-endian format. Therefore, swap the bytes if we are building for a
little-endian host.

Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Michael Walle <michael@walle.cc>
---
 hw/display/milkymist-vgafb_template.h |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/hw/display/milkymist-vgafb_template.h b/hw/display/milkymist-vgafb_template.h
index e0036e1..5a906af 100644
--- a/hw/display/milkymist-vgafb_template.h
+++ b/hw/display/milkymist-vgafb_template.h
@@ -62,6 +62,9 @@ static void glue(draw_line_, BITS)(void *opaque, uint8_t *d, const uint8_t *s,
 
     while (width--) {
         memcpy(&rgb565, s, sizeof(rgb565));
+#ifndef HOST_WORDS_BIGENDIAN
+        rgb565 = bswap16(rgb565);
+#endif
         r = ((rgb565 >> 11) & 0x1f) << 3;
         g = ((rgb565 >>  5) & 0x3f) << 2;
         b = ((rgb565 >>  0) & 0x1f) << 3;
-- 
1.7.10.4

  parent reply	other threads:[~2013-09-25 19:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-25 18:59 [Qemu-devel] [PULL 00/11] target-lm32 updates Michael Walle
2013-09-25 18:59 ` [Qemu-devel] [PULL 01/11] lm32_sys: increase test case name length limit Michael Walle
2013-09-25 18:59 ` [Qemu-devel] [PULL 02/11] tests: lm32: new rule for single test cases Michael Walle
2013-09-25 18:59 ` [Qemu-devel] [PULL 03/11] milkymist-uart: use qemu_chr_fe_write_all() instead of qemu_chr_fe_write() Michael Walle
2013-09-25 18:59 ` [Qemu-devel] [PULL 04/11] lm32_uart/lm32_juart: use qemu_chr_fe_write_all() Michael Walle
2013-09-25 18:59 ` [Qemu-devel] [PULL 05/11] target-lm32: register helper functions Michael Walle
2013-09-25 18:59 ` Michael Walle [this message]
2013-09-25 18:59 ` [Qemu-devel] [PULL 07/11] target-lm32: kill cpu_abort() calls Michael Walle
2013-09-25 18:59 ` [Qemu-devel] [PULL 08/11] target-lm32: move model features to LM32CPU Michael Walle
2013-09-25 18:59 ` [Qemu-devel] [PULL 09/11] target-lm32: add breakpoint/watchpoint support Michael Walle
2013-09-25 18:59 ` [Qemu-devel] [PULL 10/11] lm32_sys: print test result on stderr Michael Walle
2013-09-25 18:59 ` [Qemu-devel] [PULL 11/11] lm32_sys: dump cpu state if test case fails Michael Walle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1380135572-25095-7-git-send-email-michael@walle.cc \
    --to=michael@walle.cc \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).