From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54841) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VPa8x-00067Z-AR for qemu-devel@nongnu.org; Fri, 27 Sep 2013 11:39:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VPa8s-0007Nc-Fi for qemu-devel@nongnu.org; Fri, 27 Sep 2013 11:39:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:65140) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VPa8s-0007NV-8W for qemu-devel@nongnu.org; Fri, 27 Sep 2013 11:39:42 -0400 From: Kevin Wolf Date: Fri, 27 Sep 2013 17:39:05 +0200 Message-Id: <1380296370-14523-6-git-send-email-kwolf@redhat.com> In-Reply-To: <1380296370-14523-1-git-send-email-kwolf@redhat.com> References: <1380296370-14523-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PULL 05/30] block/get_block_status: set *pnum = 0 on error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: kwolf@redhat.com, qemu-devel@nongnu.org From: Peter Lieven if the call is invoked through bdrv_is_allocated the caller might expect *pnum = 0 on error. however, a new implementation of bdrv_get_block_status might only return a negative exit value on error while keeping *pnum untouched. Reviewed-by: Eric Blake Signed-off-by: Peter Lieven Signed-off-by: Kevin Wolf --- block.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block.c b/block.c index b383b72..9b444b3 100644 --- a/block.c +++ b/block.c @@ -3162,6 +3162,7 @@ static int64_t coroutine_fn bdrv_co_get_block_status(BlockDriverState *bs, ret = bs->drv->bdrv_co_get_block_status(bs, sector_num, nb_sectors, pnum); if (ret < 0) { + *pnum = 0; return ret; } -- 1.8.1.4