From: Amos Kong <akong@redhat.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, anthony@codemonkey.ws, peter.maydell@linaro.org
Subject: [Qemu-devel] [PATCH] extend limit of physical sections number
Date: Sat, 28 Sep 2013 00:49:20 +0800 [thread overview]
Message-ID: <1380300560-21086-1-git-send-email-akong@redhat.com> (raw)
# qemu -drive file=/disk0,if=none,id=v0,format=qcow2 \
-device virtio-blk-pci,drive=v0,id=v00,multifunction=on,addr=0x04.0
....
Launching guest with more than 32 virtio-blk disks,
qemu will crash, because there are too many BARs.
This patch brings the limit of non-tcg up by a factor
of 8 (32767 / 4096), i.e. 32*8 = 256.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Amos Kong <akong@redhat.com>
---
exec.c | 17 ++++++++++++-----
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/exec.c b/exec.c
index 5aef833..f639c01 100644
--- a/exec.c
+++ b/exec.c
@@ -763,11 +763,18 @@ void phys_mem_set_alloc(void *(*alloc)(ram_addr_t))
static uint16_t phys_section_add(MemoryRegionSection *section)
{
- /* The physical section number is ORed with a page-aligned
- * pointer to produce the iotlb entries. Thus it should
- * never overflow into the page-aligned value.
- */
- assert(next_map.sections_nb < TARGET_PAGE_SIZE);
+ if (tcg_enabled()) {
+ /* The physical section number is ORed with a page-aligned
+ * pointer to produce the iotlb entries. Thus it should
+ * never overflow into the page-aligned value.
+ */
+ assert(next_map.sections_nb < TARGET_PAGE_SIZE);
+ } else {
+ /* For KVM or Xen we can use the full range of the ptr field
+ * in PhysPageEntry.
+ */
+ assert(next_map.sections_nb < SHRT_MAX);
+ }
if (next_map.sections_nb == next_map.sections_nb_alloc) {
next_map.sections_nb_alloc = MAX(next_map.sections_nb_alloc * 2,
--
1.8.3.1
next reply other threads:[~2013-09-27 16:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-27 16:49 Amos Kong [this message]
2013-09-27 16:52 ` [Qemu-devel] [PATCH] extend limit of physical sections number Paolo Bonzini
2013-11-05 0:21 ` Amos Kong
2013-11-05 0:36 ` Peter Maydell
2013-11-05 9:00 ` Paolo Bonzini
2013-11-05 12:23 ` Peter Maydell
2013-11-05 12:27 ` Paolo Bonzini
2013-11-19 11:11 ` Amos Kong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380300560-21086-1-git-send-email-akong@redhat.com \
--to=akong@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).