qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 01/14] q35: make pci window address/size match guest cfg
Date: Sun, 29 Sep 2013 09:59:54 +0300	[thread overview]
Message-ID: <1380437951-21788-2-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1380437951-21788-1-git-send-email-mst@redhat.com>

For Q35, MMCFG address and size are guest configurable.
Update w32 property to make it behave accordingly.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 hw/pci-host/q35.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c
index 5473504..72f6b72 100644
--- a/hw/pci-host/q35.c
+++ b/hw/pci-host/q35.c
@@ -214,6 +214,16 @@ static void mch_update_pciexbar(MCHPCIState *mch)
     }
     addr = pciexbar & addr_mask;
     pcie_host_mmcfg_update(pehb, enable, addr, length);
+    /* Leave enough space for the MCFG BAR */
+    /*
+     * TODO: this matches current bios behaviour, but it's not a power of two,
+     * which means an MTRR can't cover it exactly.
+     */
+    if (enable) {
+        mch->pci_info.w32.begin = addr + length;
+    } else {
+        mch->pci_info.w32.begin = MCH_HOST_BRIDGE_PCIEXBAR_DEFAULT;
+    }
 }
 
 /* PAM */
-- 
MST

  reply	other threads:[~2013-09-29  6:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-29  6:59 [Qemu-devel] [PULL 00/14] pc,pci,virtio fixes and cleanups Michael S. Tsirkin
2013-09-29  6:59 ` Michael S. Tsirkin [this message]
2013-09-29  6:59 ` [Qemu-devel] [PULL 02/14] range: add Range to typedefs Michael S. Tsirkin
2013-09-29  6:59 ` [Qemu-devel] [PULL 03/14] range: add min/max operations on ranges Michael S. Tsirkin
2013-09-29  7:00 ` [Qemu-devel] [PULL 04/14] pci: add helper to retrieve the 64-bit range Michael S. Tsirkin
2013-09-29  7:00 ` [Qemu-devel] [PULL 05/14] q35: use 64 bit window programmed by guest Michael S. Tsirkin
2013-09-29  7:00 ` [Qemu-devel] [PULL 06/14] piix: " Michael S. Tsirkin
2013-09-29  7:00 ` [Qemu-devel] [PULL 07/14] piix4: disable io on reset Michael S. Tsirkin
2013-09-29  7:00 ` [Qemu-devel] [PULL 08/14] pci: remove explicit check to 64K ioport size Michael S. Tsirkin
2013-09-29  7:00 ` [Qemu-devel] [PULL 09/14] virtio-net: fix up HMP NIC info string on reset Michael S. Tsirkin
2013-09-29  7:00 ` [Qemu-devel] [PULL 10/14] smbios: Normalize smbios_entry_add()'s error handling to exit(1) Michael S. Tsirkin
2013-09-29  7:00 ` [Qemu-devel] [PULL 11/14] smbios: Convert to QemuOpts Michael S. Tsirkin
2013-09-29  7:00 ` [Qemu-devel] [PULL 12/14] smbios: Improve diagnostics for conflicting entries Michael S. Tsirkin
2013-09-29  7:00 ` [Qemu-devel] [PULL 13/14] smbios: Make multiple -smbios type= accumulate sanely Michael S. Tsirkin
2013-09-29  7:00 ` [Qemu-devel] [PULL 14/14] smbios: Factor out smbios_maybe_add_str() Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1380437951-21788-2-git-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).