From: Gerd Hoffmann <kraxel@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Mark Langsdorf" <mark.langsdorf@calxeda.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Fabien Chouteau" <chouteau@adacore.com>,
"Alexander Graf" <agraf@suse.de>,
"Blue Swirl" <blauwirbel@gmail.com>,
"Michael Walle" <michael@walle.cc>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Paul Brook" <paul@codesourcery.com>,
"Anthony Liguori" <anthony@codemonkey.ws>,
"open list:New World" <qemu-ppc@nongnu.org>,
"Andreas Färber" <andreas.faerber@web.de>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] turn firmware image filename into a machine option
Date: Tue, 01 Oct 2013 13:22:03 +0200 [thread overview]
Message-ID: <1380626523.5280.27.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <CAFEAcA9bkaVsW+6-TMNniw2ECS12cXckU5aokxt=jBQCTgHKMQ@mail.gmail.com>
On Di, 2013-10-01 at 19:55 +0900, Peter Maydell wrote:
> On 1 October 2013 18:39, Gerd Hoffmann <kraxel@redhat.com> wrote:
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> > ---
> > hw/alpha/dp264.c | 2 +-
> > hw/arm/highbank.c | 8 ++++----
> > hw/i386/pc.c | 6 ++++--
> > hw/i386/pc_piix.c | 3 ++-
> > hw/i386/pc_q35.c | 3 ++-
> > hw/i386/pc_sysfw.c | 8 +++++---
> > hw/lm32/milkymist.c | 8 ++++----
> > hw/mips/mips_fulong2e.c | 8 ++++----
> > hw/mips/mips_jazz.c | 9 ++++++---
> > hw/mips/mips_malta.c | 8 ++++----
> > hw/mips/mips_mipssim.c | 7 ++++---
> > hw/mips/mips_r4k.c | 9 +++++----
> > hw/ppc/mac_newworld.c | 9 +++++----
> > hw/ppc/mac_oldworld.c | 9 +++++----
> > hw/ppc/ppc405_boards.c | 24 ++++++++++++++----------
> > hw/ppc/prep.c | 11 ++++++-----
> > hw/ppc/spapr.c | 6 +++---
> > hw/s390x/ipl.c | 1 +
> > hw/sh4/shix.c | 11 ++++++-----
> > hw/sparc/leon3.c | 6 +++---
> > hw/sparc/sun4m.c | 2 +-
> > hw/sparc64/sun4u.c | 2 +-
> > include/hw/boards.h | 1 +
> > include/hw/i386/pc.h | 6 ++++--
> > include/sysemu/sysemu.h | 2 --
> > vl.c | 12 +++++++++---
>
> No documentation or definition of what the semantics of
> specifying a "firmware image" filename are?
"-machine firmware=$file" has the same effect as "-bios $file", which is
simliar to '-machine kernel=$file' and '-kernel $file'.
With this patch the firmware/bios filename goes into QemuOpts and thus
can be set via -readconfig $file. It's also possible to set the default
firmware image per machine type (via QEMUMachine->default_machine_opts =
"firmware=$filename").
[ I'll make the commit message more verbose for v2 ]
> Why is this a machine option rather than a property of
> the ROM/flash device?
Not all machines have a flash device. Also flash drives don't want a
simple (readonly) image file but a (writable) blockdev as backing
storage, at least the pflash device emulation I've briefly looked at.
cheers,
Gerd
next prev parent reply other threads:[~2013-10-01 11:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-01 9:39 [Qemu-devel] [PATCH] turn firmware image filename into a machine option Gerd Hoffmann
2013-10-01 10:55 ` Peter Maydell
2013-10-01 11:22 ` Gerd Hoffmann [this message]
2013-10-01 11:32 ` Peter Maydell
2013-10-01 12:16 ` Gerd Hoffmann
2013-10-01 12:20 ` Andreas Färber
2013-10-01 13:41 ` Gerd Hoffmann
2013-10-01 13:46 ` Andreas Färber
2013-10-01 14:23 ` Alexey Kardashevskiy
2013-10-01 14:40 ` Gerd Hoffmann
2013-10-01 14:45 ` Alexander Graf
2013-10-01 21:23 ` Benjamin Herrenschmidt
2013-10-02 1:18 ` Alexey Kardashevskiy
2013-10-01 13:00 ` Peter Maydell
2013-10-01 14:57 ` Paolo Bonzini
2013-10-01 15:05 ` Gerd Hoffmann
2013-10-01 15:12 ` Peter Maydell
2013-10-01 15:28 ` Paolo Bonzini
2013-10-01 15:42 ` Anthony Liguori
[not found] ` <524AB29F.3030906@suse.de>
2013-10-01 13:32 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380626523.5280.27.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=agraf@suse.de \
--cc=andreas.faerber@web.de \
--cc=anthony@codemonkey.ws \
--cc=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=chouteau@adacore.com \
--cc=hpoussin@reactos.org \
--cc=mark.langsdorf@calxeda.com \
--cc=michael@walle.cc \
--cc=paul@codesourcery.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).