From: Gerd Hoffmann <kraxel@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Mark Langsdorf" <mark.langsdorf@calxeda.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Fabien Chouteau" <chouteau@adacore.com>,
"Alexander Graf" <agraf@suse.de>,
"Blue Swirl" <blauwirbel@gmail.com>,
"Michael Walle" <michael@walle.cc>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Paul Brook" <paul@codesourcery.com>,
"Anthony Liguori" <anthony@codemonkey.ws>,
"open list:New World" <qemu-ppc@nongnu.org>,
"Andreas Färber" <andreas.faerber@web.de>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] turn firmware image filename into a machine option
Date: Tue, 01 Oct 2013 14:16:11 +0200 [thread overview]
Message-ID: <1380629771.5280.40.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <CAFEAcA8xvePFPoxKwdqBFOf4LjfMF4_P68NmuVCGmu3S+qQO9Q@mail.gmail.com>
Hi,
> -bios we're stuck with because it's a legacy
> option,
What is legacy about it?
Well, the x86-centric name of course. Thats why the machine option is
named 'firmware' instead.
It also doesn't use QemuOpts, which is fixed by this patch.
Anything else?
> >> Why is this a machine option rather than a property of
> >> the ROM/flash device?
> >
> > Not all machines have a flash device.
>
> No, but they must have *something* that the firmware code lives in...
Some don't. They just memcpy the firmware into guest ram instead.
Most have a memory region for the firmware which gets mapped into guest
address space. Sometimes pulled out of thin air, sometimes modeled as
proper device.
> > Also flash drives don't want a
> > simple (readonly) image file but a (writable) blockdev as backing
> > storage, at least the pflash device emulation I've briefly looked at.
>
> ...so how does this work for machines where the firmware lives in
> a flash device?
pc: In case '-pflash $blockdev' is present '-bios $image' is ignored.
My patch doesn't change that behavior, i.e. -machine firmware=$image is
ignored too in case -plflash is present on the command line.
Given that pflash operates on a blockdev I don't see a obvious way to
change that ...
cheers,
Gerd
next prev parent reply other threads:[~2013-10-01 12:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-01 9:39 [Qemu-devel] [PATCH] turn firmware image filename into a machine option Gerd Hoffmann
2013-10-01 10:55 ` Peter Maydell
2013-10-01 11:22 ` Gerd Hoffmann
2013-10-01 11:32 ` Peter Maydell
2013-10-01 12:16 ` Gerd Hoffmann [this message]
2013-10-01 12:20 ` Andreas Färber
2013-10-01 13:41 ` Gerd Hoffmann
2013-10-01 13:46 ` Andreas Färber
2013-10-01 14:23 ` Alexey Kardashevskiy
2013-10-01 14:40 ` Gerd Hoffmann
2013-10-01 14:45 ` Alexander Graf
2013-10-01 21:23 ` Benjamin Herrenschmidt
2013-10-02 1:18 ` Alexey Kardashevskiy
2013-10-01 13:00 ` Peter Maydell
2013-10-01 14:57 ` Paolo Bonzini
2013-10-01 15:05 ` Gerd Hoffmann
2013-10-01 15:12 ` Peter Maydell
2013-10-01 15:28 ` Paolo Bonzini
2013-10-01 15:42 ` Anthony Liguori
[not found] ` <524AB29F.3030906@suse.de>
2013-10-01 13:32 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380629771.5280.40.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=agraf@suse.de \
--cc=andreas.faerber@web.de \
--cc=anthony@codemonkey.ws \
--cc=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=chouteau@adacore.com \
--cc=hpoussin@reactos.org \
--cc=mark.langsdorf@calxeda.com \
--cc=michael@walle.cc \
--cc=paul@codesourcery.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).