From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55836) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRLj5-0007G6-Cm for qemu-devel@nongnu.org; Wed, 02 Oct 2013 08:40:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VRLj0-0007ZL-9E for qemu-devel@nongnu.org; Wed, 02 Oct 2013 08:40:23 -0400 Received: from nodalink.pck.nerim.net ([62.212.105.220]:42253 helo=paradis.irqsave.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRLiz-0007ZC-TO for qemu-devel@nongnu.org; Wed, 02 Oct 2013 08:40:18 -0400 From: =?UTF-8?q?Beno=C3=AEt=20Canet?= Date: Wed, 2 Oct 2013 14:39:20 +0200 Message-Id: <1380717564-11098-8-git-send-email-benoit@irqsave.net> In-Reply-To: <1380717564-11098-1-git-send-email-benoit@irqsave.net> References: <1380717564-11098-1-git-send-email-benoit@irqsave.net> Subject: [Qemu-devel] [PATCH V9 07/11] quorum: Add quorum_getlength(). List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, =?UTF-8?q?Beno=C3=AEt=20Canet?= , stefanha@redhat.com Check that every bs file return the same length. If not return -EIO to disable the quorum and avoid length discrepancy. Signed-off-by: Benoit Canet --- block/quorum.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index e235ac1..b3649a4 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -541,12 +541,38 @@ static BlockDriverAIOCB *quorum_aio_writev(BlockDriverState *bs, return &acb->common; } +static int64_t quorum_getlength(BlockDriverState *bs) +{ + BDRVQuorumState *s = bs->opaque; + int64_t result; + int i; + + /* check that all file have the same length */ + result = bdrv_getlength(&s->bs[0]); + if (result < 0) { + return result; + } + for (i = 1; i < s->total; i++) { + int64_t value = bdrv_getlength(&s->bs[i]); + if (value < 0) { + return value; + } + if (value != result) { + return -EIO; + } + } + + return result; +} + static BlockDriver bdrv_quorum = { .format_name = "quorum", .protocol_name = "quorum", .instance_size = sizeof(BDRVQuorumState), + .bdrv_getlength = quorum_getlength, + .bdrv_aio_readv = quorum_aio_readv, .bdrv_aio_writev = quorum_aio_writev, }; -- 1.8.1.2