From: Stefan Weil <sw@weilnetz.de>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Stefan Weil <sw@weilnetz.de>, Sebastian Ottlik <ottlik@fzi.de>,
qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] [PULL 2/5] gdbstub: call socket_set_fast_reuse instead of setting SO_REUSEADDR
Date: Wed, 2 Oct 2013 19:41:26 +0200 [thread overview]
Message-ID: <1380735690-24009-3-git-send-email-sw@weilnetz.de> (raw)
In-Reply-To: <1380735690-24009-1-git-send-email-sw@weilnetz.de>
From: Sebastian Ottlik <ottlik@fzi.de>
SO_REUSEADDR should be avoided on Windows but is desired on other operating
systems. So instead of setting it we call socket_set_fast_reuse that will result
in the appropriate behaviour on all operating systems.
Signed-off-by: Sebastian Ottlik <ottlik@fzi.de>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
gdbstub.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/gdbstub.c b/gdbstub.c
index 2b7f22b..0e5a3f5 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -1553,7 +1553,7 @@ static void gdb_accept(void)
static int gdbserver_open(int port)
{
struct sockaddr_in sockaddr;
- int fd, val, ret;
+ int fd, ret;
fd = socket(PF_INET, SOCK_STREAM, 0);
if (fd < 0) {
@@ -1564,9 +1564,7 @@ static int gdbserver_open(int port)
fcntl(fd, F_SETFD, FD_CLOEXEC);
#endif
- /* allow fast reuse */
- val = 1;
- qemu_setsockopt(fd, SOL_SOCKET, SO_REUSEADDR, &val, sizeof(val));
+ socket_set_fast_reuse(fd);
sockaddr.sin_family = AF_INET;
sockaddr.sin_port = htons(port);
--
1.7.10.4
next prev parent reply other threads:[~2013-10-02 17:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 17:41 [Qemu-devel] [PULL 0/5] net: Add and use new function socket_set_fast_reuse Stefan Weil
2013-10-02 17:41 ` [Qemu-devel] [PULL 1/5] util: add socket_set_fast_reuse function which will replace setting SO_REUSEADDR Stefan Weil
2013-10-02 17:41 ` Stefan Weil [this message]
2013-10-02 17:41 ` [Qemu-devel] [PULL 3/5] net: call socket_set_fast_reuse instead of " Stefan Weil
2013-10-02 17:41 ` [Qemu-devel] [PULL 4/5] slirp: " Stefan Weil
2013-10-02 17:41 ` [Qemu-devel] [PULL 5/5] util: " Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380735690-24009-3-git-send-email-sw@weilnetz.de \
--to=sw@weilnetz.de \
--cc=anthony@codemonkey.ws \
--cc=ottlik@fzi.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).