From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35936) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRQRG-0003fz-0j for qemu-devel@nongnu.org; Wed, 02 Oct 2013 13:42:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VRQR1-00056i-GC for qemu-devel@nongnu.org; Wed, 02 Oct 2013 13:42:17 -0400 Received: from qemu.weilnetz.de ([37.221.198.45]:47195 helo=v2201305906712890.yourvserver.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRQR1-00056H-88 for qemu-devel@nongnu.org; Wed, 02 Oct 2013 13:42:03 -0400 From: Stefan Weil Date: Wed, 2 Oct 2013 19:41:26 +0200 Message-Id: <1380735690-24009-3-git-send-email-sw@weilnetz.de> In-Reply-To: <1380735690-24009-1-git-send-email-sw@weilnetz.de> References: <1380735690-24009-1-git-send-email-sw@weilnetz.de> Subject: [Qemu-devel] [PULL 2/5] gdbstub: call socket_set_fast_reuse instead of setting SO_REUSEADDR List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Stefan Weil , Sebastian Ottlik , qemu-devel From: Sebastian Ottlik SO_REUSEADDR should be avoided on Windows but is desired on other operating systems. So instead of setting it we call socket_set_fast_reuse that will result in the appropriate behaviour on all operating systems. Signed-off-by: Sebastian Ottlik Reviewed-by: Eric Blake Signed-off-by: Stefan Weil --- gdbstub.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 2b7f22b..0e5a3f5 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1553,7 +1553,7 @@ static void gdb_accept(void) static int gdbserver_open(int port) { struct sockaddr_in sockaddr; - int fd, val, ret; + int fd, ret; fd = socket(PF_INET, SOCK_STREAM, 0); if (fd < 0) { @@ -1564,9 +1564,7 @@ static int gdbserver_open(int port) fcntl(fd, F_SETFD, FD_CLOEXEC); #endif - /* allow fast reuse */ - val = 1; - qemu_setsockopt(fd, SOL_SOCKET, SO_REUSEADDR, &val, sizeof(val)); + socket_set_fast_reuse(fd); sockaddr.sin_family = AF_INET; sockaddr.sin_port = htons(port); -- 1.7.10.4