qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jia Liu <proljc@gmail.com>
To: qemu-devel@nongnu.org
Cc: sebastian@macke.de, aliguori@us.ibm.com,
	stefan.kristiansson@saunalahti.fi
Subject: [Qemu-devel] [PULL 2/2] target-openrisc: Removes a non-conforming behavior for the first page of the memory
Date: Thu,  3 Oct 2013 16:41:42 +0800	[thread overview]
Message-ID: <1380789702-18935-3-git-send-email-proljc@gmail.com> (raw)
In-Reply-To: <1380789702-18935-1-git-send-email-proljc@gmail.com>

From: Sebastian Macke <sebastian@macke.de>

Where *software* leaves 0x0000 - 0x2000 unmapped, the hardware should
still allow for this area to be mapped.

Signed-off-by: Sebastian Macke <sebastian@macke.de>
Signed-off-by: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
Reviewed-by: Jia Liu <proljc@gmail.com>
---
 target-openrisc/mmu.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/target-openrisc/mmu.c b/target-openrisc/mmu.c
index 323a173..22d7cbe 100644
--- a/target-openrisc/mmu.c
+++ b/target-openrisc/mmu.c
@@ -122,13 +122,6 @@ static int cpu_openrisc_get_phys_addr(OpenRISCCPU *cpu,
 {
     int ret = TLBRET_MATCH;
 
-    /* [0x0000--0x2000]: unmapped */
-    if (address < 0x2000 && (cpu->env.sr & SR_SM)) {
-        *physical = address;
-        *prot = PAGE_READ | PAGE_WRITE;
-        return ret;
-    }
-
     if (rw == 2) {    /* ITLB */
        *physical = 0;
         ret = cpu->env.tlb->cpu_openrisc_map_address_code(cpu, physical,
-- 
1.7.12.4 (Apple Git-37)

  parent reply	other threads:[~2013-10-03  8:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-03  8:41 [Qemu-devel] [PULL 0/2] Correction of the TLB handling of the OpenRISC target Jia Liu
2013-10-03  8:41 ` [Qemu-devel] [PULL 1/2] target-openrisc: Correct handling of page faults Jia Liu
2013-10-03  8:41 ` Jia Liu [this message]
2013-10-03  9:00 ` [Qemu-devel] [PULL 0/2] Correction of the TLB handling of the OpenRISC target Peter Maydell
2013-10-03 12:06   ` Jia Liu
2013-10-14  9:06   ` Jia Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1380789702-18935-3-git-send-email-proljc@gmail.com \
    --to=proljc@gmail.com \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sebastian@macke.de \
    --cc=stefan.kristiansson@saunalahti.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).