qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>
Cc: pbonzini@redhat.com, imammedo@redhat.com, afaerber@suse.de,
	kraxel@redhat.com
Subject: [Qemu-devel] [PATCH v7 10/26] q35: expose mmcfg size as a property
Date: Thu, 3 Oct 2013 16:21:31 +0300	[thread overview]
Message-ID: <1380806439-32587-11-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1380806439-32587-1-git-send-email-mst@redhat.com>

Address is already exposed, expose size for symmetry.

Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
Tested-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 include/hw/pci/pcie_host.h |  1 +
 hw/pci-host/q35.c          | 14 ++++++++++++++
 2 files changed, 15 insertions(+)

diff --git a/include/hw/pci/pcie_host.h b/include/hw/pci/pcie_host.h
index 33d75bd..acca45e 100644
--- a/include/hw/pci/pcie_host.h
+++ b/include/hw/pci/pcie_host.h
@@ -29,6 +29,7 @@
     OBJECT_CHECK(PCIExpressHost, (obj), TYPE_PCIE_HOST_BRIDGE)
 
 #define PCIE_HOST_MCFG_BASE "MCFG"
+#define PCIE_HOST_MCFG_SIZE "mcfg_size"
 
 /* pcie_host::base_addr == PCIE_BASE_ADDR_UNMAPPED when it isn't mapped. */
 #define PCIE_BASE_ADDR_UNMAPPED  ((hwaddr)-1ULL)
diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c
index e46f286..a051b58 100644
--- a/hw/pci-host/q35.c
+++ b/hw/pci-host/q35.c
@@ -109,6 +109,16 @@ static void q35_host_get_pci_hole64_end(Object *obj, Visitor *v,
     visit_type_uint64(v, &w64.end, name, errp);
 }
 
+static void q35_host_get_mmcfg_size(Object *obj, Visitor *v,
+                                    void *opaque, const char *name,
+                                    Error **errp)
+{
+    PCIExpressHost *e = PCIE_HOST_BRIDGE(obj);
+    uint32_t value = e->size;
+
+    visit_type_uint32(v, &value, name, errp);
+}
+
 static Property mch_props[] = {
     DEFINE_PROP_UINT64(PCIE_HOST_MCFG_BASE, Q35PCIHost, parent_obj.base_addr,
                         MCH_HOST_BRIDGE_PCIEXBAR_DEFAULT),
@@ -160,6 +170,10 @@ static void q35_host_initfn(Object *obj)
                         q35_host_get_pci_hole64_end,
                         NULL, NULL, NULL, NULL);
 
+    object_property_add(obj, PCIE_HOST_MCFG_SIZE, "int",
+                        q35_host_get_mmcfg_size,
+                        NULL, NULL, NULL, NULL);
+
     /* Leave enough space for the biggest MCFG BAR */
     /* TODO: this matches current bios behaviour, but
      * it's not a power of two, which means an MTRR
-- 
MST

  parent reply	other threads:[~2013-10-03 13:19 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-03 13:20 [Qemu-devel] [PATCH v7 00/26] qemu: generate acpi tables for the guest Michael S. Tsirkin
2013-10-03 13:21 ` [Qemu-devel] [PATCH v7 01/26] cleanup object.h: include error.h directly Michael S. Tsirkin
2013-10-03 13:21 ` [Qemu-devel] [PATCH v7 02/26] qom: cleanup struct Error references Michael S. Tsirkin
2013-10-03 13:21 ` [Qemu-devel] [PATCH v7 03/26] qom: add pointer to int property helpers Michael S. Tsirkin
2013-10-03 13:21 ` [Qemu-devel] [PATCH v7 04/26] pci: fix up w64 size calculation helper Michael S. Tsirkin
2013-10-03 13:21 ` [Qemu-devel] [PATCH v7 05/26] fw_cfg: interface to trigger callback on read Michael S. Tsirkin
2013-10-03 13:21 ` [Qemu-devel] [PATCH v7 06/26] loader: support for unmapped ROM blobs Michael S. Tsirkin
2013-10-03 13:21 ` [Qemu-devel] [PATCH v7 07/26] pcie_host: expose UNMAPPED macro Michael S. Tsirkin
2013-10-03 13:21 ` [Qemu-devel] [PATCH v7 08/26] pcie_host: expose address format Michael S. Tsirkin
2013-10-03 13:21 ` [Qemu-devel] [PATCH v7 09/26] q35: use macro for MCFG property name Michael S. Tsirkin
2013-10-03 13:21 ` Michael S. Tsirkin [this message]
2013-10-03 13:21 ` [Qemu-devel] [PATCH v7 11/26] i386: add ACPI table files from seabios Michael S. Tsirkin
2013-10-03 13:21 ` [Qemu-devel] [PATCH v7 12/26] acpi: add rules to compile ASL source Michael S. Tsirkin
2013-10-03 13:21 ` [Qemu-devel] [PATCH v7 13/26] acpi: pre-compiled ASL files Michael S. Tsirkin
2013-10-03 13:21 ` [Qemu-devel] [PATCH v7 14/26] acpi: ssdt pcihp: updat generated file Michael S. Tsirkin
2013-10-03 13:21 ` [Qemu-devel] [PATCH v7 15/26] loader: use file path size from fw_cfg.h Michael S. Tsirkin
2013-10-03 13:21 ` [Qemu-devel] [PATCH v7 16/26] i386: add bios linker/loader Michael S. Tsirkin
2013-10-03 13:21 ` [Qemu-devel] [PATCH v7 17/26] loader: allow adding ROMs in done callbacks Michael S. Tsirkin
2013-10-03 13:22 ` [Qemu-devel] [PATCH v7 18/26] i386: define pc guest info Michael S. Tsirkin
2013-10-03 13:22 ` [Qemu-devel] [PATCH v7 19/26] acpi/piix: add macros for acpi property names Michael S. Tsirkin
2013-10-03 13:22 ` [Qemu-devel] [PATCH v7 20/26] piix: APIs for pc guest info Michael S. Tsirkin
2013-10-03 13:22 ` [Qemu-devel] [PATCH v7 21/26] ich9: " Michael S. Tsirkin
2013-10-03 13:22 ` [Qemu-devel] [PATCH v7 22/26] pvpanic: add API to access io port Michael S. Tsirkin
2013-10-03 13:22 ` [Qemu-devel] [PATCH v7 23/26] hpet: add API to find it Michael S. Tsirkin
2013-10-03 13:22 ` [Qemu-devel] [PATCH v7 24/26] i386: ACPI table generation code from seabios Michael S. Tsirkin
2013-10-03 13:22 ` [Qemu-devel] [PATCH v7 25/26] ssdt: fix PBLK length Michael S. Tsirkin
2013-10-03 13:22 ` [Qemu-devel] [PATCH v7 26/26] ssdt-proc: update generated file Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1380806439-32587-11-git-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=afaerber@suse.de \
    --cc=anthony@codemonkey.ws \
    --cc=imammedo@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).