From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>
Cc: pbonzini@redhat.com, imammedo@redhat.com,
Laszlo Ersek <lersek@redhat.com>,
afaerber@suse.de, kraxel@redhat.com
Subject: [Qemu-devel] [PATCH v7 12/26] acpi: add rules to compile ASL source
Date: Thu, 3 Oct 2013 16:21:40 +0300 [thread overview]
Message-ID: <1380806439-32587-13-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1380806439-32587-1-git-send-email-mst@redhat.com>
Detect presence of IASL compiler and use it
to process ASL source. If not there, use pre-compiled
files in-tree. Add script to update the in-tree files.
Note: distros are known to silently update iasl
so detect correct iasl flags for the installed version on each run as
opposed to at configure time.
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
Tested-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
configure | 9 ++++++++-
hw/i386/Makefile.objs | 22 ++++++++++++++++++++++
scripts/update-acpi.sh | 4 ++++
3 files changed, 34 insertions(+), 1 deletion(-)
create mode 100644 scripts/update-acpi.sh
diff --git a/configure b/configure
index 2b83936..15405e1 100755
--- a/configure
+++ b/configure
@@ -119,6 +119,7 @@ path_of() {
# default parameters
source_path=`dirname "$0"`
cpu=""
+iasl="iasl"
interp_prefix="/usr/gnemul/qemu-%M"
static="no"
cross_prefix=""
@@ -257,6 +258,8 @@ for opt do
;;
--cxx=*) CXX="$optarg"
;;
+ --iasl=*) iasl="$optarg"
+ ;;
--source-path=*) source_path="$optarg"
;;
--cpu=*) cpu="$optarg"
@@ -1055,6 +1058,7 @@ echo "Advanced options (experts only):"
echo " --source-path=PATH path of source code [$source_path]"
echo " --cross-prefix=PREFIX use PREFIX for compile tools [$cross_prefix]"
echo " --cc=CC use C compiler CC [$cc]"
+echo " --iasl=IASL use ACPI compiler IASL [$iasl]"
echo " --host-cc=CC use C compiler CC [$host_cc] for code run at"
echo " build time"
echo " --cxx=CXX use C++ compiler CXX [$cxx]"
@@ -4239,6 +4243,9 @@ else
fi
echo "PYTHON=$python" >> $config_host_mak
echo "CC=$cc" >> $config_host_mak
+if $iasl -h > /dev/null 2>&1; then
+ echo "IASL=$iasl" >> $config_host_mak
+fi
echo "CC_I386=$cc_i386" >> $config_host_mak
echo "HOST_CC=$host_cc" >> $config_host_mak
echo "CXX=$cxx" >> $config_host_mak
@@ -4691,7 +4698,7 @@ for rom in seabios vgabios ; do
echo "BCC=bcc" >> $config_mak
echo "CPP=$cpp" >> $config_mak
echo "OBJCOPY=objcopy" >> $config_mak
- echo "IASL=iasl" >> $config_mak
+ echo "IASL=$iasl" >> $config_mak
echo "LD=$ld" >> $config_mak
done
diff --git a/hw/i386/Makefile.objs b/hw/i386/Makefile.objs
index 45e6165..f950707 100644
--- a/hw/i386/Makefile.objs
+++ b/hw/i386/Makefile.objs
@@ -5,3 +5,25 @@ obj-y += pc_sysfw.o
obj-$(CONFIG_XEN) += xen_domainbuild.o xen_machine_pv.o
obj-y += kvmvapic.o
+
+iasl-option=$(shell if test -z "`$(1) $(2) 2>&1 > /dev/null`" \
+ ; then echo "$(2)"; else echo "$(3)"; fi ;)
+
+ifdef IASL
+#IASL Present. Generate hex files from .dsl
+hw/i386/%.hex: $(SRC_PATH)/hw/i386/%.dsl $(SRC_PATH)/scripts/acpi_extract_preprocess.py $(SRC_PATH)/scripts/acpi_extract.py
+ $(call quiet-command, cpp -P $< -o $*.dsl.i.orig, " CPP $(TARGET_DIR)$*.dsl.i.orig")
+ $(call quiet-command, $(PYTHON) $(SRC_PATH)/scripts/acpi_extract_preprocess.py $*.dsl.i.orig > $*.dsl.i, " ACPI_PREPROCESS $(TARGET_DIR)$*.dsl.i")
+ $(call quiet-command, $(IASL) $(call iasl-option,$(IASL),-Pn,) -vs -l -tc -p $* $*.dsl.i $(if $(V), , > /dev/null) 2>&1 ," IASL $(TARGET_DIR)$*.dsl.i")
+ $(call quiet-command, $(SRC_PATH)/scripts/acpi_extract.py $*.lst > $*.off, " ACPI_EXTRACT $(TARGET_DIR)$*.off")
+ $(call quiet-command, cat $*.off > $@, " CAT $(TARGET_DIR)$@")
+else
+#IASL Not present. Restore pre-generated hex files.
+hw/i386/%.hex: $(SRC_PATH)/hw/i386/%.hex.generated
+ $(call quiet-command, cp -f $< $@, " CP $(TARGET_DIR)$@")
+endif
+
+.PHONY: cleanhex
+cleanhex:
+ rm -f hw/i386/*hex
+clean: cleanhex
diff --git a/scripts/update-acpi.sh b/scripts/update-acpi.sh
new file mode 100644
index 0000000..b5f05ff
--- /dev/null
+++ b/scripts/update-acpi.sh
@@ -0,0 +1,4 @@
+cd x86_64-softmmu
+for file in hw/i386/*.hex; do
+ cp -f $file ../$file.generated
+done
--
MST
next prev parent reply other threads:[~2013-10-03 13:19 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 13:20 [Qemu-devel] [PATCH v7 00/26] qemu: generate acpi tables for the guest Michael S. Tsirkin
2013-10-03 13:21 ` [Qemu-devel] [PATCH v7 01/26] cleanup object.h: include error.h directly Michael S. Tsirkin
2013-10-03 13:21 ` [Qemu-devel] [PATCH v7 02/26] qom: cleanup struct Error references Michael S. Tsirkin
2013-10-03 13:21 ` [Qemu-devel] [PATCH v7 03/26] qom: add pointer to int property helpers Michael S. Tsirkin
2013-10-03 13:21 ` [Qemu-devel] [PATCH v7 04/26] pci: fix up w64 size calculation helper Michael S. Tsirkin
2013-10-03 13:21 ` [Qemu-devel] [PATCH v7 05/26] fw_cfg: interface to trigger callback on read Michael S. Tsirkin
2013-10-03 13:21 ` [Qemu-devel] [PATCH v7 06/26] loader: support for unmapped ROM blobs Michael S. Tsirkin
2013-10-03 13:21 ` [Qemu-devel] [PATCH v7 07/26] pcie_host: expose UNMAPPED macro Michael S. Tsirkin
2013-10-03 13:21 ` [Qemu-devel] [PATCH v7 08/26] pcie_host: expose address format Michael S. Tsirkin
2013-10-03 13:21 ` [Qemu-devel] [PATCH v7 09/26] q35: use macro for MCFG property name Michael S. Tsirkin
2013-10-03 13:21 ` [Qemu-devel] [PATCH v7 10/26] q35: expose mmcfg size as a property Michael S. Tsirkin
2013-10-03 13:21 ` [Qemu-devel] [PATCH v7 11/26] i386: add ACPI table files from seabios Michael S. Tsirkin
2013-10-03 13:21 ` Michael S. Tsirkin [this message]
2013-10-03 13:21 ` [Qemu-devel] [PATCH v7 13/26] acpi: pre-compiled ASL files Michael S. Tsirkin
2013-10-03 13:21 ` [Qemu-devel] [PATCH v7 14/26] acpi: ssdt pcihp: updat generated file Michael S. Tsirkin
2013-10-03 13:21 ` [Qemu-devel] [PATCH v7 15/26] loader: use file path size from fw_cfg.h Michael S. Tsirkin
2013-10-03 13:21 ` [Qemu-devel] [PATCH v7 16/26] i386: add bios linker/loader Michael S. Tsirkin
2013-10-03 13:21 ` [Qemu-devel] [PATCH v7 17/26] loader: allow adding ROMs in done callbacks Michael S. Tsirkin
2013-10-03 13:22 ` [Qemu-devel] [PATCH v7 18/26] i386: define pc guest info Michael S. Tsirkin
2013-10-03 13:22 ` [Qemu-devel] [PATCH v7 19/26] acpi/piix: add macros for acpi property names Michael S. Tsirkin
2013-10-03 13:22 ` [Qemu-devel] [PATCH v7 20/26] piix: APIs for pc guest info Michael S. Tsirkin
2013-10-03 13:22 ` [Qemu-devel] [PATCH v7 21/26] ich9: " Michael S. Tsirkin
2013-10-03 13:22 ` [Qemu-devel] [PATCH v7 22/26] pvpanic: add API to access io port Michael S. Tsirkin
2013-10-03 13:22 ` [Qemu-devel] [PATCH v7 23/26] hpet: add API to find it Michael S. Tsirkin
2013-10-03 13:22 ` [Qemu-devel] [PATCH v7 24/26] i386: ACPI table generation code from seabios Michael S. Tsirkin
2013-10-03 13:22 ` [Qemu-devel] [PATCH v7 25/26] ssdt: fix PBLK length Michael S. Tsirkin
2013-10-03 13:22 ` [Qemu-devel] [PATCH v7 26/26] ssdt-proc: update generated file Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380806439-32587-13-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=imammedo@redhat.com \
--cc=kraxel@redhat.com \
--cc=lersek@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).