qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Corey J. Boyle" <corey@kansanian.com>
To: qemu-devel@nongnu.org
Cc: Riku Voipio <riku.voipio@iki.fi>, "Corey J. Boyle" <corey@kansanian.com>
Subject: [Qemu-devel] [PATCH] flatload: fix non-GOT relocations
Date: Fri,  4 Oct 2013 18:50:30 -0400	[thread overview]
Message-ID: <1380927030-28198-1-git-send-email-corey@kansanian.com> (raw)

From: "Corey J. Boyle" <corey@kansanian.com>

Use target address rather than host address when performing
non-GOT relocations

Signed-off-by: Corey J. Boyle <corey@kansanian.com>
---
 linux-user/flatload.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/linux-user/flatload.c b/linux-user/flatload.c
index 58f679e..c13a201 100644
--- a/linux-user/flatload.c
+++ b/linux-user/flatload.c
@@ -44,7 +44,7 @@
 #define ntohl(x) be32_to_cpu(x)
 #include <target_flat.h>
 
-//#define DEBUG
+#define DEBUG
 
 #ifdef DEBUG
 #define	DBG_FLT(...)	printf(__VA_ARGS__)
@@ -633,7 +633,7 @@ static int load_flat_file(struct linux_binprm * bprm,
             /* Get the pointer's value.  */
             if (get_user_ual(addr, rp))
                 return -EFAULT;
-            addr = flat_get_addr_from_rp(rp, relval, flags, &persistent);
+            addr = flat_get_addr_from_rp(addr, relval, flags, &persistent);
             if (addr != 0) {
                 /*
                  * Do the relocation.  PIC relocs in the data section are
-- 
1.7.9.5

             reply	other threads:[~2013-10-04 22:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-04 22:50 Corey J. Boyle [this message]
2013-10-05  8:04 ` [Qemu-devel] [PATCH] flatload: fix non-GOT relocations Peter Maydell
2013-10-05 11:28   ` Corey Boyle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1380927030-28198-1-git-send-email-corey@kansanian.com \
    --to=corey@kansanian.com \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).