From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44049) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VT53R-0003S7-9T for qemu-devel@nongnu.org; Mon, 07 Oct 2013 03:16:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VT53I-0002Dc-EN for qemu-devel@nongnu.org; Mon, 07 Oct 2013 03:16:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2184) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VT53I-0002DY-61 for qemu-devel@nongnu.org; Mon, 07 Oct 2013 03:16:24 -0400 Message-ID: <1381130180.13574.13.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Mon, 07 Oct 2013 09:16:20 +0200 In-Reply-To: <524C1C42.8050502@siemens.com> References: <1379583298-7524-1-git-send-email-kraxel@redhat.com> <1379583298-7524-2-git-send-email-kraxel@redhat.com> <524C1C42.8050502@siemens.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/7] usb: remove old usb-host code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel@nongnu.org On Mi, 2013-10-02 at 15:14 +0200, Jan Kiszka wrote: > On 2013-09-19 11:34, Gerd Hoffmann wrote: > > The usb-host code has been rewritten for qemu 1.5 to use libusb, > > the old code has been left in as temporary fallback. Now we are > > two releases further out, targeting the 1.7 release. No major > > issues with the new code poped up until now. Time to remove it > > from tre tree. Should we ever need it again for some reason -- > > git has a copy for us in the history. > > Well, maybe not many users were actually exploiting the new libusb code, > thus were able to produce feedback. > > Only very recent distros fulfill the need of >= 1.0.13, so you naturally > fall back to this code. I just realized that even the factory build of > OpenSUSE is still on libusb-1.0.9. Current Ubuntu versions are on 1.0.12 > at best. Didn't check others so far. Ouch. The 1.0.13 release is one year old by now. Fedora 19 is at 1.0.16 btw. > So isn't this step a bit too early? There is always the 'git revert' option in case it turns out there are too many issues ... cheers, Gerd