From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>
Cc: pbonzini@redhat.com, imammedo@redhat.com, afaerber@suse.de,
kraxel@redhat.com
Subject: [Qemu-devel] [PATCH v9 02/27] qom: cleanup struct Error references
Date: Mon, 7 Oct 2013 12:34:56 +0300 [thread overview]
Message-ID: <1381138458-6848-3-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1381138458-6848-1-git-send-email-mst@redhat.com>
now that a typedef for struct Error is available,
use it in qom/object.h to match coding style rules.
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
Tested-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/qom/object.h | 50 +++++++++++++++++++++++++-------------------------
1 file changed, 25 insertions(+), 25 deletions(-)
diff --git a/include/qom/object.h b/include/qom/object.h
index d9a0063..6c1e7d3 100644
--- a/include/qom/object.h
+++ b/include/qom/object.h
@@ -301,7 +301,7 @@ typedef void (ObjectPropertyAccessor)(Object *obj,
struct Visitor *v,
void *opaque,
const char *name,
- struct Error **errp);
+ Error **errp);
/**
* ObjectPropertyRelease:
@@ -790,9 +790,9 @@ void object_property_add(Object *obj, const char *name, const char *type,
ObjectPropertyAccessor *get,
ObjectPropertyAccessor *set,
ObjectPropertyRelease *release,
- void *opaque, struct Error **errp);
+ void *opaque, Error **errp);
-void object_property_del(Object *obj, const char *name, struct Error **errp);
+void object_property_del(Object *obj, const char *name, Error **errp);
/**
* object_property_find:
@@ -803,7 +803,7 @@ void object_property_del(Object *obj, const char *name, struct Error **errp);
* Look up a property for an object and return its #ObjectProperty if found.
*/
ObjectProperty *object_property_find(Object *obj, const char *name,
- struct Error **errp);
+ Error **errp);
void object_unparent(Object *obj);
@@ -818,7 +818,7 @@ void object_unparent(Object *obj);
* Reads a property from a object.
*/
void object_property_get(Object *obj, struct Visitor *v, const char *name,
- struct Error **errp);
+ Error **errp);
/**
* object_property_set_str:
@@ -829,7 +829,7 @@ void object_property_get(Object *obj, struct Visitor *v, const char *name,
* Writes a string value to a property.
*/
void object_property_set_str(Object *obj, const char *value,
- const char *name, struct Error **errp);
+ const char *name, Error **errp);
/**
* object_property_get_str:
@@ -842,7 +842,7 @@ void object_property_set_str(Object *obj, const char *value,
* The caller should free the string.
*/
char *object_property_get_str(Object *obj, const char *name,
- struct Error **errp);
+ Error **errp);
/**
* object_property_set_link:
@@ -853,7 +853,7 @@ char *object_property_get_str(Object *obj, const char *name,
* Writes an object's canonical path to a property.
*/
void object_property_set_link(Object *obj, Object *value,
- const char *name, struct Error **errp);
+ const char *name, Error **errp);
/**
* object_property_get_link:
@@ -866,7 +866,7 @@ void object_property_set_link(Object *obj, Object *value,
* string or not a valid object path).
*/
Object *object_property_get_link(Object *obj, const char *name,
- struct Error **errp);
+ Error **errp);
/**
* object_property_set_bool:
@@ -877,7 +877,7 @@ Object *object_property_get_link(Object *obj, const char *name,
* Writes a bool value to a property.
*/
void object_property_set_bool(Object *obj, bool value,
- const char *name, struct Error **errp);
+ const char *name, Error **errp);
/**
* object_property_get_bool:
@@ -889,7 +889,7 @@ void object_property_set_bool(Object *obj, bool value,
* an error occurs (including when the property value is not a bool).
*/
bool object_property_get_bool(Object *obj, const char *name,
- struct Error **errp);
+ Error **errp);
/**
* object_property_set_int:
@@ -900,7 +900,7 @@ bool object_property_get_bool(Object *obj, const char *name,
* Writes an integer value to a property.
*/
void object_property_set_int(Object *obj, int64_t value,
- const char *name, struct Error **errp);
+ const char *name, Error **errp);
/**
* object_property_get_int:
@@ -912,7 +912,7 @@ void object_property_set_int(Object *obj, int64_t value,
* an error occurs (including when the property value is not an integer).
*/
int64_t object_property_get_int(Object *obj, const char *name,
- struct Error **errp);
+ Error **errp);
/**
* object_property_set:
@@ -926,7 +926,7 @@ int64_t object_property_get_int(Object *obj, const char *name,
* Writes a property to a object.
*/
void object_property_set(Object *obj, struct Visitor *v, const char *name,
- struct Error **errp);
+ Error **errp);
/**
* object_property_parse:
@@ -938,7 +938,7 @@ void object_property_set(Object *obj, struct Visitor *v, const char *name,
* Parses a string and writes the result into a property of an object.
*/
void object_property_parse(Object *obj, const char *string,
- const char *name, struct Error **errp);
+ const char *name, Error **errp);
/**
* object_property_print:
@@ -950,7 +950,7 @@ void object_property_parse(Object *obj, const char *string,
* caller shall free the string.
*/
char *object_property_print(Object *obj, const char *name,
- struct Error **errp);
+ Error **errp);
/**
* object_property_get_type:
@@ -961,7 +961,7 @@ char *object_property_print(Object *obj, const char *name,
* Returns: The type name of the property.
*/
const char *object_property_get_type(Object *obj, const char *name,
- struct Error **errp);
+ Error **errp);
/**
* object_get_root:
@@ -1054,7 +1054,7 @@ Object *object_resolve_path_component(Object *parent, const gchar *part);
* The child object itself can be retrieved using object_property_get_link().
*/
void object_property_add_child(Object *obj, const char *name,
- Object *child, struct Error **errp);
+ Object *child, Error **errp);
/**
* object_property_add_link:
@@ -1077,7 +1077,7 @@ void object_property_add_child(Object *obj, const char *name,
*/
void object_property_add_link(Object *obj, const char *name,
const char *type, Object **child,
- struct Error **errp);
+ Error **errp);
/**
* object_property_add_str:
@@ -1092,9 +1092,9 @@ void object_property_add_link(Object *obj, const char *name,
* property of type 'string'.
*/
void object_property_add_str(Object *obj, const char *name,
- char *(*get)(Object *, struct Error **),
- void (*set)(Object *, const char *, struct Error **),
- struct Error **errp);
+ char *(*get)(Object *, Error **),
+ void (*set)(Object *, const char *, Error **),
+ Error **errp);
/**
* object_property_add_bool:
@@ -1108,9 +1108,9 @@ void object_property_add_str(Object *obj, const char *name,
* property of type 'bool'.
*/
void object_property_add_bool(Object *obj, const char *name,
- bool (*get)(Object *, struct Error **),
- void (*set)(Object *, bool, struct Error **),
- struct Error **errp);
+ bool (*get)(Object *, Error **),
+ void (*set)(Object *, bool, Error **),
+ Error **errp);
/**
* object_child_foreach:
--
MST
next prev parent reply other threads:[~2013-10-07 9:32 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-07 9:34 [Qemu-devel] [PATCH v9 00/27] qemu: generate acpi tables for the guest Michael S. Tsirkin
2013-10-07 9:34 ` [Qemu-devel] [PATCH v9 01/27] cleanup object.h: include error.h directly Michael S. Tsirkin
2013-10-07 9:34 ` Michael S. Tsirkin [this message]
2013-10-07 9:35 ` [Qemu-devel] [PATCH v9 03/27] qom: add pointer to int property helpers Michael S. Tsirkin
2013-10-07 9:35 ` [Qemu-devel] [PATCH v9 04/27] pci: fix up w64 size calculation helper Michael S. Tsirkin
2013-10-07 9:35 ` [Qemu-devel] [PATCH v9 05/27] fw_cfg: interface to trigger callback on read Michael S. Tsirkin
2013-10-07 9:35 ` [Qemu-devel] [PATCH v9 06/27] loader: support for unmapped ROM blobs Michael S. Tsirkin
2013-10-07 9:35 ` [Qemu-devel] [PATCH v9 07/27] pcie_host: expose UNMAPPED macro Michael S. Tsirkin
2013-10-07 9:35 ` [Qemu-devel] [PATCH v9 08/27] pcie_host: expose address format Michael S. Tsirkin
2013-10-07 9:35 ` [Qemu-devel] [PATCH v9 09/27] q35: use macro for MCFG property name Michael S. Tsirkin
2013-10-07 9:35 ` [Qemu-devel] [PATCH v9 10/27] q35: expose mmcfg size as a property Michael S. Tsirkin
2013-10-07 9:35 ` [Qemu-devel] [PATCH v9 11/27] i386: add ACPI table files from seabios Michael S. Tsirkin
2013-10-07 9:35 ` [Qemu-devel] [PATCH v9 12/27] acpi: add rules to compile ASL source Michael S. Tsirkin
2013-10-07 9:35 ` [Qemu-devel] [PATCH v9 13/27] acpi: pre-compiled ASL files Michael S. Tsirkin
2013-10-07 9:35 ` [Qemu-devel] [PATCH v9 14/27] acpi: ssdt pcihp: updat generated file Michael S. Tsirkin
2013-10-07 9:36 ` [Qemu-devel] [PATCH v9 15/27] loader: use file path size from fw_cfg.h Michael S. Tsirkin
2013-10-07 9:36 ` [Qemu-devel] [PATCH v9 16/27] i386: add bios linker/loader Michael S. Tsirkin
2013-10-07 9:36 ` [Qemu-devel] [PATCH v9 17/27] loader: allow adding ROMs in done callbacks Michael S. Tsirkin
2013-10-07 9:36 ` [Qemu-devel] [PATCH v9 18/27] i386: define pc guest info Michael S. Tsirkin
2013-10-07 9:36 ` [Qemu-devel] [PATCH v9 19/27] acpi/piix: add macros for acpi property names Michael S. Tsirkin
2013-10-07 9:36 ` [Qemu-devel] [PATCH v9 20/27] piix: APIs for pc guest info Michael S. Tsirkin
2013-10-07 9:36 ` [Qemu-devel] [PATCH v9 21/27] ich9: " Michael S. Tsirkin
2013-10-07 9:36 ` [Qemu-devel] [PATCH v9 22/27] pvpanic: add API to access io port Michael S. Tsirkin
2013-10-07 9:36 ` [Qemu-devel] [PATCH v9 23/27] hpet: add API to find it Michael S. Tsirkin
2013-10-07 9:36 ` [Qemu-devel] [PATCH v9 24/27] i386: ACPI table generation code from seabios Michael S. Tsirkin
2013-10-07 9:36 ` [Qemu-devel] [PATCH v9 25/27] ssdt: fix PBLK length Michael S. Tsirkin
2013-10-07 9:36 ` [Qemu-devel] [PATCH v9 26/27] ssdt-proc: update generated file Michael S. Tsirkin
2013-10-07 9:36 ` [Qemu-devel] [PATCH v9 27/27] don't post me: update bios Michael S. Tsirkin
2013-10-07 13:18 ` [Qemu-devel] [PATCH v9 00/27] qemu: generate acpi tables for the guest Igor Mammedov
2013-10-07 17:18 ` Andreas Färber
2013-10-13 16:49 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381138458-6848-3-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=imammedo@redhat.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).