From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: alex@alex.org.uk
Subject: [Qemu-devel] [PATCH 3/8] timers: use cpu_get_icount() directly
Date: Tue, 8 Oct 2013 10:47:33 +0200 [thread overview]
Message-ID: <1381222058-16701-4-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1381222058-16701-1-git-send-email-pbonzini@redhat.com>
This will help later when we will have to place these calls in
a critical section, and thus call a version of cpu_get_icount()
that does not take the lock.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
cpus.c | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/cpus.c b/cpus.c
index 870a832..f87ff6f 100644
--- a/cpus.c
+++ b/cpus.c
@@ -224,12 +224,15 @@ static void icount_adjust(void)
int64_t cur_icount;
int64_t delta;
static int64_t last_delta;
+
/* If the VM is not running, then do nothing. */
if (!runstate_is_running()) {
return;
}
+
cur_time = cpu_get_clock();
- cur_icount = qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL);
+ cur_icount = cpu_get_icount();
+
delta = cur_icount - cur_time;
/* FIXME: This is a very crude algorithm, somewhat prone to oscillation. */
if (delta > 0
@@ -285,7 +288,7 @@ static void icount_warp_rt(void *opaque)
* far ahead of real time.
*/
int64_t cur_time = cpu_get_clock();
- int64_t cur_icount = qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL);
+ int64_t cur_icount = cpu_get_icount();
int64_t delta = cur_time - cur_icount;
qemu_icount_bias += MIN(warp_delta, delta);
}
--
1.8.3.1
next prev parent reply other threads:[~2013-10-08 8:48 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 8:47 [Qemu-devel] [PATCH 0/8] Make icount thread-safe Paolo Bonzini
2013-10-08 8:47 ` [Qemu-devel] [PATCH 1/8] timers: extract timer_mod_ns_locked and timerlist_rearm Paolo Bonzini
2013-10-08 9:06 ` Alex Bligh
2013-10-08 8:47 ` [Qemu-devel] [PATCH 2/8] timers: add timer_mod_anticipate and timer_mod_anticipate_ns Paolo Bonzini
2013-10-08 9:15 ` Alex Bligh
2013-10-08 9:25 ` Paolo Bonzini
2013-10-08 17:01 ` Alex Bligh
2013-10-08 8:47 ` Paolo Bonzini [this message]
2013-10-08 16:49 ` [Qemu-devel] [PATCH 3/8] timers: use cpu_get_icount() directly Alex Bligh
2013-10-08 8:47 ` [Qemu-devel] [PATCH 4/8] timers: reorganize icount_warp_rt Paolo Bonzini
2013-10-08 16:50 ` Alex Bligh
2013-10-08 8:47 ` [Qemu-devel] [PATCH 5/8] timers: prepare the code for future races in calling qemu_clock_warp Paolo Bonzini
2013-10-08 16:54 ` Alex Bligh
2013-10-08 16:56 ` Paolo Bonzini
2013-10-08 17:08 ` Alex Bligh
2013-10-08 17:10 ` Paolo Bonzini
2013-10-08 8:47 ` [Qemu-devel] [PATCH 6/8] timers: introduce cpu_get_clock_locked Paolo Bonzini
2013-10-08 16:55 ` Alex Bligh
2013-10-08 8:47 ` [Qemu-devel] [PATCH 7/8] timers: document (future) locking rules for icount Paolo Bonzini
2013-10-08 16:56 ` Alex Bligh
2013-10-08 8:47 ` [Qemu-devel] [PATCH 8/8] timers: make icount thread-safe Paolo Bonzini
2013-10-08 16:57 ` Alex Bligh
2013-10-08 13:47 ` [Qemu-devel] [PATCH 0/8] Make " Andreas Färber
2013-10-08 13:55 ` Paolo Bonzini
2013-11-05 9:27 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381222058-16701-4-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex@alex.org.uk \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).