qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Lieven <pl@kamp.de>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, ronniesahlberg@gmail.com,
	Peter Lieven <pl@kamp.de>,
	stefanha@redhat.com, anthony@codemonkey.ws, pbonzini@redhat.com
Subject: [Qemu-devel] [PATCHv4 11/17] iscsi: add bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes
Date: Tue,  8 Oct 2013 13:58:05 +0200	[thread overview]
Message-ID: <1381233491-17019-12-git-send-email-pl@kamp.de> (raw)
In-Reply-To: <1381233491-17019-1-git-send-email-pl@kamp.de>

Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Peter Lieven <pl@kamp.de>
---
 block/iscsi.c |   16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/block/iscsi.c b/block/iscsi.c
index 8ed2274..f0ac620 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -1449,6 +1449,18 @@ static int iscsi_has_zero_init(BlockDriverState *bs)
     return 0;
 }
 
+static bool iscsi_has_discard_zeroes(BlockDriverState *bs)
+{
+    IscsiLun *iscsilun = bs->opaque;
+    return !!iscsilun->lbprz;
+}
+
+static bool iscsi_has_discard_write_zeroes(BlockDriverState *bs)
+{
+    IscsiLun *iscsilun = bs->opaque;
+    return iscsilun->lbprz && iscsilun->lbp.lbpws;
+}
+
 static int iscsi_create(const char *filename, QEMUOptionParameter *options,
                         Error **errp)
 {
@@ -1535,7 +1547,9 @@ static BlockDriver bdrv_iscsi = {
     .bdrv_aio_writev = iscsi_aio_writev,
     .bdrv_aio_flush  = iscsi_aio_flush,
 
-    .bdrv_has_zero_init = iscsi_has_zero_init,
+    .bdrv_has_zero_init            = iscsi_has_zero_init,
+    .bdrv_has_discard_zeroes       = iscsi_has_discard_zeroes,
+    .bdrv_has_discard_write_zeroes = iscsi_has_discard_write_zeroes,
 
 #ifdef __linux__
     .bdrv_ioctl       = iscsi_ioctl,
-- 
1.7.9.5

  parent reply	other threads:[~2013-10-08 12:00 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-08 11:57 [Qemu-devel] [PATCHv4 00/17] block: logical block provisioning enhancements Peter Lieven
2013-10-08 11:57 ` [Qemu-devel] [PATCHv4 01/17] block: make BdrvRequestFlags public Peter Lieven
2013-10-08 11:57 ` [Qemu-devel] [PATCHv4 02/17] block: add flags to bdrv_*_write_zeroes Peter Lieven
2013-10-08 11:57 ` [Qemu-devel] [PATCHv4 03/17] block: introduce BDRV_REQ_MAY_UNMAP request flag Peter Lieven
2013-10-08 11:57 ` [Qemu-devel] [PATCHv4 04/17] block: introduce bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes Peter Lieven
2013-10-08 11:57 ` [Qemu-devel] [PATCHv4 05/17] block/raw: add " Peter Lieven
2013-10-08 11:58 ` [Qemu-devel] [PATCHv4 06/17] block: add BlockLimits structure to BlockDriverState Peter Lieven
2013-10-08 11:58 ` [Qemu-devel] [PATCHv4 07/17] block: honour BlockLimits in bdrv_co_do_write_zeroes Peter Lieven
2013-10-08 11:58 ` [Qemu-devel] [PATCHv4 08/17] block: honour BlockLimits in bdrv_co_discard Peter Lieven
2013-10-08 11:58 ` [Qemu-devel] [PATCHv4 09/17] iscsi: simplify iscsi_co_discard Peter Lieven
2013-10-08 11:58 ` [Qemu-devel] [PATCHv4 10/17] iscsi: set limits in BlockDriverState Peter Lieven
2013-10-08 11:58 ` Peter Lieven [this message]
2013-10-08 11:58 ` [Qemu-devel] [PATCHv4 12/17] iscsi: add bdrv_co_write_zeroes Peter Lieven
2013-10-08 11:58 ` [Qemu-devel] [PATCHv4 13/17] block: introduce bdrv_make_zero Peter Lieven
2013-10-08 11:58 ` [Qemu-devel] [PATCHv4 14/17] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks Peter Lieven
2013-10-18 12:38   ` Stefan Hajnoczi
2013-10-18 12:49     ` Paolo Bonzini
2013-10-18 13:24       ` Stefan Hajnoczi
2013-10-18 13:52         ` Peter Lieven
2013-10-18 13:58           ` Paolo Bonzini
2013-10-18 13:26       ` Peter Lieven
2013-10-18 13:50         ` Paolo Bonzini
2013-10-18 19:10           ` Peter Lieven
2013-10-30  8:28             ` Stefan Hajnoczi
2013-10-30 21:22               ` Peter Lieven
2013-10-18 13:20     ` Peter Lieven
2013-10-08 11:58 ` [Qemu-devel] [PATCHv4 15/17] qemu-img: add support for fully allocated images Peter Lieven
2013-10-08 11:58 ` [Qemu-devel] [PATCHv4 16/17] qemu-img: conditionally zero out target on convert Peter Lieven
2013-10-18 12:26   ` Stefan Hajnoczi
2013-10-08 11:58 ` [Qemu-devel] [PATCHv4 17/17] block/raw: copy BlockLimits on raw_open Peter Lieven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1381233491-17019-12-git-send-email-pl@kamp.de \
    --to=pl@kamp.de \
    --cc=anthony@codemonkey.ws \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=ronniesahlberg@gmail.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).