From: Max Reitz <mreitz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Max Reitz <mreitz@redhat.com>
Subject: [Qemu-devel] [PATCH 0/3] qcow2: Small error path fixes for snapshot writing
Date: Wed, 9 Oct 2013 10:51:03 +0200 [thread overview]
Message-ID: <1381308666-24268-1-git-send-email-mreitz@redhat.com> (raw)
Errors in qcow2_write_snapshots should always go down the error path. If
this path is taken, the newly allocated snapshot table clusters are
abandoned and should thus be freed.
Furthermore, we should safeguard against a possible future increase of
QEMU's maximum snapshot name/ID length.
Max Reitz (3):
qcow2: Always use error path on writing snapshots
qcow2: Free allocated snapshot table on error
qcow2: Assert against snapshot name/ID overflow
block/qcow2-snapshot.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
--
1.8.3.1
next reply other threads:[~2013-10-09 8:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-09 8:51 Max Reitz [this message]
2013-10-09 8:51 ` [Qemu-devel] [PATCH 1/3] qcow2: Always use error path on writing snapshots Max Reitz
2013-10-09 8:51 ` [Qemu-devel] [PATCH 2/3] qcow2: Free allocated snapshot table on error Max Reitz
2013-10-09 8:51 ` [Qemu-devel] [PATCH 3/3] qcow2: Assert against snapshot name/ID overflow Max Reitz
2013-10-09 9:53 ` [Qemu-devel] [PATCH 0/3] qcow2: Small error path fixes for snapshot writing Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381308666-24268-1-git-send-email-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).