[Qemu-devel] [PATCH 2/2] vmdk: refuse enabling zeroed grain with flat images

[Fam Zheng <famz@redhat.com>]

This is a header flag and we needs sparse for the header.

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 block/vmdk.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/block/vmdk.c b/block/vmdk.c
index a98ad23..78c0129 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -1656,6 +1656,10 @@ static int vmdk_create(const char *filename, QEMUOptionParameter *options,
         error_setg(errp, "flat image can't have backing file");
         return -ENOTSUP;
     }
+    if (flat && zeroed_grain) {
+        error_setg(errp, "flat image can't enable zeroed grain");
+        return -ENOTSUP;
+    }
     if (backing_file) {
         BlockDriverState *bs = bdrv_new("");
         ret = bdrv_open(bs, backing_file, NULL, 0, NULL, &local_err);
-- 
1.8.3.1