From: Liu Ping Fan <qemulist@gmail.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Anthony Liguori <anthony@codemonkey.ws>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] [PATCH v6 2/5] hpet: enable to entitle more irq pins for hpet
Date: Thu, 10 Oct 2013 15:56:16 +0800 [thread overview]
Message-ID: <1381391779-27718-3-git-send-email-pingfank@linux.vnet.ibm.com> (raw)
In-Reply-To: <1381391779-27718-1-git-send-email-pingfank@linux.vnet.ibm.com>
On q35, IRQ2/8 can be reserved for hpet timer 0/1. And pin 16~23
of ioapic can be dynamically assigned to hpet as guest chooses.
So we introduce intcap property to do that. (currently, its value
is IRQ2. Later, it should be set by board.)
Signed-off-by: Liu Ping Fan <pingfank@linux.vnet.ibm.com>
---
hw/timer/hpet.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/hw/timer/hpet.c b/hw/timer/hpet.c
index 8429eb3..5b11be4 100644
--- a/hw/timer/hpet.c
+++ b/hw/timer/hpet.c
@@ -25,6 +25,7 @@
*/
#include "hw/hw.h"
+#include "hw/boards.h"
#include "hw/i386/pc.h"
#include "ui/console.h"
#include "qemu/timer.h"
@@ -42,6 +43,9 @@
#define HPET_MSI_SUPPORT 0
+/* Will fix: intcap is set by board, and should be 0 if nobody sets. */
+#define HPET_TN_INT_CAP_DEFAULT 0x4ULL
+
#define TYPE_HPET "hpet"
#define HPET(obj) OBJECT_CHECK(HPETState, (obj), TYPE_HPET)
@@ -73,6 +77,7 @@ typedef struct HPETState {
uint8_t rtc_irq_level;
qemu_irq pit_enabled;
uint8_t num_timers;
+ uint32_t intcap;
HPETTimer timer[HPET_MAX_TIMERS];
/* Memory-mapped, software visible registers */
@@ -663,8 +668,8 @@ static void hpet_reset(DeviceState *d)
if (s->flags & (1 << HPET_MSI_SUPPORT)) {
timer->config |= HPET_TN_FSB_CAP;
}
- /* advertise availability of ioapic inti2 */
- timer->config |= 0x00000004ULL << 32;
+ /* advertise availability of ioapic int */
+ timer->config |= (uint64_t)s->intcap << 32;
timer->period = 0ULL;
timer->wrap_flag = 0;
}
@@ -753,6 +758,7 @@ static void hpet_realize(DeviceState *dev, Error **errp)
static Property hpet_device_properties[] = {
DEFINE_PROP_UINT8("timers", HPETState, num_timers, HPET_MIN_TIMERS),
DEFINE_PROP_BIT("msi", HPETState, flags, HPET_MSI_SUPPORT, false),
+ DEFINE_PROP_UINT32("intcap", HPETState, intcap, HPET_TN_INT_CAP_DEFAULT),
DEFINE_PROP_END_OF_LIST(),
};
--
1.8.1.4
next prev parent reply other threads:[~2013-10-10 7:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-10 7:56 [Qemu-devel] [PATCH v6 0/5] bugs fix for hpet Liu Ping Fan
2013-10-10 7:56 ` [Qemu-devel] [PATCH v6 1/5] hpet: inverse polarity when pin above ISA_NUM_IRQS Liu Ping Fan
2013-10-10 7:56 ` Liu Ping Fan [this message]
2013-10-10 9:11 ` [Qemu-devel] [PATCH v6 2/5] hpet: enable to entitle more irq pins for hpet Paolo Bonzini
2013-10-11 2:59 ` liu ping fan
2013-10-10 9:16 ` Michael S. Tsirkin
2013-10-10 9:33 ` Paolo Bonzini
2013-10-10 9:41 ` Michael S. Tsirkin
2013-10-10 9:46 ` Paolo Bonzini
2013-10-10 11:41 ` Michael S. Tsirkin
2013-10-11 2:59 ` liu ping fan
2013-10-11 8:38 ` Paolo Bonzini
2013-10-11 9:18 ` liu ping fan
2013-10-11 11:28 ` Paolo Bonzini
2013-10-14 14:17 ` Michael S. Tsirkin
2013-10-14 14:18 ` Michael S. Tsirkin
2013-10-15 5:24 ` liu ping fan
2013-10-10 7:56 ` [Qemu-devel] [PATCH v6 3/5] PC: use qdev_xx to create hpet instead of sysbus_create_xx Liu Ping Fan
2013-10-10 9:10 ` Paolo Bonzini
2013-10-10 9:24 ` Michael S. Tsirkin
2013-10-10 7:56 ` [Qemu-devel] [PATCH v6 4/5] PC: add hpet compat to trace compatability version Liu Ping Fan
2013-10-10 9:09 ` Paolo Bonzini
2013-10-10 7:56 ` [Qemu-devel] [PATCH v6 5/5] PC: differentiate hpet's interrupt capability on piix and q35 Liu Ping Fan
2013-10-10 9:23 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381391779-27718-3-git-send-email-pingfank@linux.vnet.ibm.com \
--to=qemulist@gmail.com \
--cc=anthony@codemonkey.ws \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).