qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Max Reitz <mreitz@redhat.com>
Subject: [Qemu-devel] [PATCH 1/5] block/raw_bsd: Employ error parameter
Date: Thu, 10 Oct 2013 15:44:00 +0200	[thread overview]
Message-ID: <1381412644-16212-2-git-send-email-mreitz@redhat.com> (raw)
In-Reply-To: <1381412644-16212-1-git-send-email-mreitz@redhat.com>

Propagate errors in raw_create rather than directly reporting and
afterwards discarding them.

Signed-off-by: Max Reitz <mreitz@redhat.com>
---
 block/raw_bsd.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/block/raw_bsd.c b/block/raw_bsd.c
index d61906b..0078c1b 100644
--- a/block/raw_bsd.c
+++ b/block/raw_bsd.c
@@ -140,8 +140,7 @@ static int raw_create(const char *filename, QEMUOptionParameter *options,
 
     ret = bdrv_create_file(filename, options, &local_err);
     if (error_is_set(&local_err)) {
-        qerror_report_err(local_err);
-        error_free(local_err);
+        error_propagate(errp, local_err);
     }
     return ret;
 }
-- 
1.8.3.1

  reply	other threads:[~2013-10-10 13:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-10 13:43 [Qemu-devel] [PATCH 0/5] block: Employ error parameter Max Reitz
2013-10-10 13:44 ` Max Reitz [this message]
2013-10-10 13:44 ` [Qemu-devel] [PATCH 2/5] block/raw-posix: " Max Reitz
2013-10-11  9:07   ` Kevin Wolf
2013-10-11 11:01     ` Markus Armbruster
2013-10-11  9:26   ` [Qemu-devel] [PATCH v2 " Max Reitz
2013-10-11  9:37   ` [Qemu-devel] [PATCH v3 " Max Reitz
2013-10-11  9:45     ` Kevin Wolf
2013-10-10 13:44 ` [Qemu-devel] [PATCH 3/5] block/raw-win32: " Max Reitz
2013-10-10 17:17   ` Eric Blake
2013-10-10 13:44 ` [Qemu-devel] [PATCH 4/5] blkdebug: " Max Reitz
2013-10-10 13:44 ` [Qemu-devel] [PATCH 5/5] blkverify: " Max Reitz
2013-10-10 17:18 ` [Qemu-devel] [PATCH 0/5] block: " Eric Blake
2013-10-11  9:33 ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1381412644-16212-2-git-send-email-mreitz@redhat.com \
    --to=mreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).