From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49727) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VUGXH-0001wa-HZ for qemu-devel@nongnu.org; Thu, 10 Oct 2013 09:44:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VUGXB-0007hJ-AJ for qemu-devel@nongnu.org; Thu, 10 Oct 2013 09:44:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10822) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VUGXB-0007hB-2J for qemu-devel@nongnu.org; Thu, 10 Oct 2013 09:44:09 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9ADi8wD032257 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 10 Oct 2013 09:44:08 -0400 From: Max Reitz Date: Thu, 10 Oct 2013 15:44:00 +0200 Message-Id: <1381412644-16212-2-git-send-email-mreitz@redhat.com> In-Reply-To: <1381412644-16212-1-git-send-email-mreitz@redhat.com> References: <1381412644-16212-1-git-send-email-mreitz@redhat.com> Subject: [Qemu-devel] [PATCH 1/5] block/raw_bsd: Employ error parameter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi , Max Reitz Propagate errors in raw_create rather than directly reporting and afterwards discarding them. Signed-off-by: Max Reitz --- block/raw_bsd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/block/raw_bsd.c b/block/raw_bsd.c index d61906b..0078c1b 100644 --- a/block/raw_bsd.c +++ b/block/raw_bsd.c @@ -140,8 +140,7 @@ static int raw_create(const char *filename, QEMUOptionParameter *options, ret = bdrv_create_file(filename, options, &local_err); if (error_is_set(&local_err)) { - qerror_report_err(local_err); - error_free(local_err); + error_propagate(errp, local_err); } return ret; } -- 1.8.3.1