From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49354) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VUHSW-00084k-Vd for qemu-devel@nongnu.org; Thu, 10 Oct 2013 10:43:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VUHSI-0007Uv-GU for qemu-devel@nongnu.org; Thu, 10 Oct 2013 10:43:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60970) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VUHSI-0007UZ-7q for qemu-devel@nongnu.org; Thu, 10 Oct 2013 10:43:10 -0400 From: armbru@redhat.com Date: Thu, 10 Oct 2013 16:42:52 +0200 Message-Id: <1381416174-5110-8-git-send-email-armbru@redhat.com> In-Reply-To: <1381416174-5110-1-git-send-email-armbru@redhat.com> References: <1381416174-5110-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH RFC 7/9] vt82c686: Document why cannot_instantiate_with_device_add_yet List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: borntraeger@de.ibm.com, afaerber@suse.de, anthony@codemonkey.ws, peter.maydell@linaro.org From: Markus Armbruster A VT82C686B southbridge has multiple functions. We model each function as a separate qdev. One of them need some special wiring set up in mips_fulong2e_init() to work: the ISA bridge at 05.0. Additionally, the IDE controller at 05.1 has always had cannot_instantiate_with_device_add_yet set, but it's not obvious to me why, so keep /* FIXME explain why */ for them. Signed-off-by: Markus Armbruster --- hw/isa/vt82c686.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c index 3e8ec80..ec7c259 100644 --- a/hw/isa/vt82c686.c +++ b/hw/isa/vt82c686.c @@ -480,8 +480,12 @@ static void via_class_init(ObjectClass *klass, void *data) k->class_id = PCI_CLASS_BRIDGE_ISA; k->revision = 0x40; dc->desc = "ISA bridge"; - dc->cannot_instantiate_with_device_add_yet = true; /* FIXME explain why */ dc->vmsd = &vmstate_via; + /* + * Reason: part of VIA VT82C686 southbridge, needs to be wired up, + * e.g. by mips_fulong2e_init() + */ + dc->cannot_instantiate_with_device_add_yet = true; } static const TypeInfo via_info = { -- 1.8.1.4