From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56499) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VUHf8-0003Ci-4T for qemu-devel@nongnu.org; Thu, 10 Oct 2013 10:56:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VUHf1-00051b-Pd for qemu-devel@nongnu.org; Thu, 10 Oct 2013 10:56:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53640) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VUHf1-00051O-GM for qemu-devel@nongnu.org; Thu, 10 Oct 2013 10:56:19 -0400 Message-ID: <1381416998.22271.19.camel@localhost.localdomain> From: Marcel Apfelbaum Date: Thu, 10 Oct 2013 17:56:38 +0300 In-Reply-To: <1381410021-1538-1-git-send-email-armbru@redhat.com> References: <1381410021-1538-1-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/2] Improve -device command line help some more List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: armbru@redhat.com Cc: qemu-devel@nongnu.org, anthony@codemonkey.ws On Thu, 2013-10-10 at 15:00 +0200, armbru@redhat.com wrote: > From: Markus Armbruster > > Marcel's recent improvements (commit dbd94f8..125ee0e) go in the right > direction, but there are issues (see PATCH 1/2), and I find the > resulting help output still hard to read. > > This series redoes the help printing part of Marcel's series. Result > looks like this (moxie picked as example for brevity): > > $ qemu-system-moxie -device help > Controller/Bridge/Hub devices: > name "usb-host", bus usb-bus > name "usb-hub", bus usb-bus > > Storage devices: > name "scsi-block", bus SCSI, desc "SCSI block device passthrough" > name "scsi-cd", bus SCSI, desc "virtual SCSI CD-ROM" > name "scsi-disk", bus SCSI, desc "virtual SCSI disk or CD-ROM (legacy)" > name "scsi-generic", bus SCSI, desc "pass through generic scsi device (/dev/sg*)" > name "scsi-hd", bus SCSI, desc "virtual SCSI disk" > > Input devices: > name "isa-serial", bus ISA > name "usb-kbd", bus usb-bus > name "usb-mouse", bus usb-bus > name "usb-tablet", bus usb-bus > > Misc devices: > name "smbus-eeprom", bus i2c-bus > name "usb-redir", bus usb-bus > > Additionally, "info qdm" is again just like "device_add help" with > no-user devices included. I think that adding the category in each line may be useful when using grep, but I suppose that we can grep by category with -A x. Thanks for continuing to improve the help output. Marcel, Reviewed-by: Marcel Apfelbaum > > Markus Armbruster (2): > Mostly revert "qemu-help: Sort devices by logical functionality" > qdev-monitor: Group "device_add help" and "info qdm" by category > > include/hw/qdev-core.h | 16 ---------- > qdev-monitor.c | 85 ++++++++++++++++++++++++++++---------------------- > 2 files changed, 47 insertions(+), 54 deletions(-) >