From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51031) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VUMYg-0001ut-OG for qemu-devel@nongnu.org; Thu, 10 Oct 2013 16:10:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VUMYY-0002KM-BN for qemu-devel@nongnu.org; Thu, 10 Oct 2013 16:10:06 -0400 Received: from mail-qc0-x22c.google.com ([2607:f8b0:400d:c01::22c]:61970) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VUMYY-0002KF-6j for qemu-devel@nongnu.org; Thu, 10 Oct 2013 16:09:58 -0400 Received: by mail-qc0-f172.google.com with SMTP id k18so2206754qcv.17 for ; Thu, 10 Oct 2013 13:09:57 -0700 (PDT) Sender: fluxion From: Michael Roth Date: Thu, 10 Oct 2013 15:09:42 -0500 Message-Id: <1381435782-25524-4-git-send-email-mdroth@linux.vnet.ibm.com> In-Reply-To: <1381435782-25524-1-git-send-email-mdroth@linux.vnet.ibm.com> References: <1381435782-25524-1-git-send-email-mdroth@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 3/3] qemu-ga: Extend 'guest-info' command to expose flag 'success-response' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: wudxw@linux.vnet.ibm.com, tomoki.sekiyama@hds.com, aliguori@amazon.com From: Mark Wu Now we have several qemu-ga commands not returning response on success. It has been documented in qga/qapi-schema.json already. This patch exposes the 'success-response' flag by extending 'guest-info' command. With this change, the clients can handle the command response more flexibly. Signed-off-by: Mark Wu Reviewed-by: Eric Blake Reviewed-by: Michael Roth *fixed up commit subject Signed-off-by: Michael Roth --- include/qapi/qmp/dispatch.h | 1 + qapi/qmp-registry.c | 5 +++++ qga/commands.c | 1 + qga/qapi-schema.json | 5 ++++- 4 files changed, 11 insertions(+), 1 deletion(-) diff --git a/include/qapi/qmp/dispatch.h b/include/qapi/qmp/dispatch.h index 7d759ef..cea3818 100644 --- a/include/qapi/qmp/dispatch.h +++ b/include/qapi/qmp/dispatch.h @@ -49,6 +49,7 @@ void qmp_disable_command(const char *name); void qmp_enable_command(const char *name); bool qmp_command_is_enabled(const QmpCommand *cmd); const char *qmp_command_name(const QmpCommand *cmd); +bool qmp_has_success_response(const QmpCommand *cmd); QObject *qmp_build_error_object(Error *errp); typedef void (*qmp_cmd_callback_fn)(QmpCommand *cmd, void *opaque); void qmp_for_each_command(qmp_cmd_callback_fn fn, void *opaque); diff --git a/qapi/qmp-registry.c b/qapi/qmp-registry.c index 5e26710..3e4498a 100644 --- a/qapi/qmp-registry.c +++ b/qapi/qmp-registry.c @@ -76,6 +76,11 @@ const char *qmp_command_name(const QmpCommand *cmd) return cmd->name; } +bool qmp_has_success_response(const QmpCommand *cmd) +{ + return !(cmd->options & QCO_NO_SUCCESS_RESP); +} + void qmp_for_each_command(qmp_cmd_callback_fn fn, void *opaque) { QmpCommand *cmd; diff --git a/qga/commands.c b/qga/commands.c index e87cbf8..a0c2de0 100644 --- a/qga/commands.c +++ b/qga/commands.c @@ -54,6 +54,7 @@ static void qmp_command_info(QmpCommand *cmd, void *opaque) cmd_info = g_malloc0(sizeof(GuestAgentCommandInfo)); cmd_info->name = g_strdup(qmp_command_name(cmd)); cmd_info->enabled = qmp_command_is_enabled(cmd); + cmd_info->success_response = qmp_has_success_response(cmd); cmd_info_list = g_malloc0(sizeof(GuestAgentCommandInfoList)); cmd_info_list->value = cmd_info; diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json index 7155b7a..245f968 100644 --- a/qga/qapi-schema.json +++ b/qga/qapi-schema.json @@ -141,10 +141,13 @@ # # @enabled: whether command is currently enabled by guest admin # +# @success-response: whether command returns a response on success +# (since 1.7) +# # Since 1.1.0 ## { 'type': 'GuestAgentCommandInfo', - 'data': { 'name': 'str', 'enabled': 'bool' } } + 'data': { 'name': 'str', 'enabled': 'bool', 'success-response': 'bool' } } ## # @GuestAgentInfo -- 1.7.9.5