[Qemu-devel] [PATCH] spapr: add vio-bus devices to categories

[Qemu-devel] [PATCH] spapr: add vio-bus devices to categories

[Alexey Kardashevskiy]

In order to get devices appear in output of
"./qemu-system-ppc64 -device ?",
they must be assigned to one of DEVICE_CATEGORY_XXXX.

This puts VIO devices classes to corresponding categories.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
 hw/char/spapr_vty.c    | 1 +
 hw/net/spapr_llan.c    | 1 +
 hw/nvram/spapr_nvram.c | 1 +
 hw/scsi/spapr_vscsi.c  | 1 +
 4 files changed, 4 insertions(+)

diff --git a/hw/char/spapr_vty.c b/hw/char/spapr_vty.c
index 9c2aef8..f8a4981 100644
--- a/hw/char/spapr_vty.c
+++ b/hw/char/spapr_vty.c
@@ -168,6 +168,7 @@ static void spapr_vty_class_init(ObjectClass *klass, void *data)
     k->dt_name = "vty";
     k->dt_type = "serial";
     k->dt_compatible = "hvterm1";
+    set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
     dc->props = spapr_vty_properties;
     dc->vmsd = &vmstate_spapr_vty;
 }
diff --git a/hw/net/spapr_llan.c b/hw/net/spapr_llan.c
index 4ff0411..1bd6f50 100644
--- a/hw/net/spapr_llan.c
+++ b/hw/net/spapr_llan.c
@@ -531,6 +531,7 @@ static void spapr_vlan_class_init(ObjectClass *klass, void *data)
     k->dt_type = "network";
     k->dt_compatible = "IBM,l-lan";
     k->signal_mask = 0x1;
+    set_bit(DEVICE_CATEGORY_NETWORK, dc->categories);
     dc->props = spapr_vlan_properties;
     k->rtce_window_size = 0x10000000;
     dc->vmsd = &vmstate_spapr_llan;
diff --git a/hw/nvram/spapr_nvram.c b/hw/nvram/spapr_nvram.c
index eb4500e..beaad68 100644
--- a/hw/nvram/spapr_nvram.c
+++ b/hw/nvram/spapr_nvram.c
@@ -182,6 +182,7 @@ static void spapr_nvram_class_init(ObjectClass *klass, void *data)
     k->dt_name = "nvram";
     k->dt_type = "nvram";
     k->dt_compatible = "qemu,spapr-nvram";
+    set_bit(DEVICE_CATEGORY_MISC, dc->categories);
     dc->props = spapr_nvram_properties;
 }
 
diff --git a/hw/scsi/spapr_vscsi.c b/hw/scsi/spapr_vscsi.c
index 2a26042..c0c46d7 100644
--- a/hw/scsi/spapr_vscsi.c
+++ b/hw/scsi/spapr_vscsi.c
@@ -1223,6 +1223,7 @@ static void spapr_vscsi_class_init(ObjectClass *klass, void *data)
     k->dt_type = "vscsi";
     k->dt_compatible = "IBM,v-scsi";
     k->signal_mask = 0x00000001;
+    set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
     dc->props = spapr_vscsi_properties;
     k->rtce_window_size = 0x10000000;
     dc->vmsd = &vmstate_spapr_vscsi;
-- 
1.8.4.rc4

Re: [Qemu-devel] [PATCH] spapr: add vio-bus devices to categories

[Alexey Kardashevskiy]

On 10/11/2013 02:08 PM, Alexey Kardashevskiy wrote:
> In order to get devices appear in output of
> "./qemu-system-ppc64 -device ?",
> they must be assigned to one of DEVICE_CATEGORY_XXXX.
> 
> This puts VIO devices classes to corresponding categories.
> 
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>


Ping?



> ---
>  hw/char/spapr_vty.c    | 1 +
>  hw/net/spapr_llan.c    | 1 +
>  hw/nvram/spapr_nvram.c | 1 +
>  hw/scsi/spapr_vscsi.c  | 1 +
>  4 files changed, 4 insertions(+)
> 
> diff --git a/hw/char/spapr_vty.c b/hw/char/spapr_vty.c
> index 9c2aef8..f8a4981 100644
> --- a/hw/char/spapr_vty.c
> +++ b/hw/char/spapr_vty.c
> @@ -168,6 +168,7 @@ static void spapr_vty_class_init(ObjectClass *klass, void *data)
>      k->dt_name = "vty";
>      k->dt_type = "serial";
>      k->dt_compatible = "hvterm1";
> +    set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
>      dc->props = spapr_vty_properties;
>      dc->vmsd = &vmstate_spapr_vty;
>  }
> diff --git a/hw/net/spapr_llan.c b/hw/net/spapr_llan.c
> index 4ff0411..1bd6f50 100644
> --- a/hw/net/spapr_llan.c
> +++ b/hw/net/spapr_llan.c
> @@ -531,6 +531,7 @@ static void spapr_vlan_class_init(ObjectClass *klass, void *data)
>      k->dt_type = "network";
>      k->dt_compatible = "IBM,l-lan";
>      k->signal_mask = 0x1;
> +    set_bit(DEVICE_CATEGORY_NETWORK, dc->categories);
>      dc->props = spapr_vlan_properties;
>      k->rtce_window_size = 0x10000000;
>      dc->vmsd = &vmstate_spapr_llan;
> diff --git a/hw/nvram/spapr_nvram.c b/hw/nvram/spapr_nvram.c
> index eb4500e..beaad68 100644
> --- a/hw/nvram/spapr_nvram.c
> +++ b/hw/nvram/spapr_nvram.c
> @@ -182,6 +182,7 @@ static void spapr_nvram_class_init(ObjectClass *klass, void *data)
>      k->dt_name = "nvram";
>      k->dt_type = "nvram";
>      k->dt_compatible = "qemu,spapr-nvram";
> +    set_bit(DEVICE_CATEGORY_MISC, dc->categories);
>      dc->props = spapr_nvram_properties;
>  }
>  
> diff --git a/hw/scsi/spapr_vscsi.c b/hw/scsi/spapr_vscsi.c
> index 2a26042..c0c46d7 100644
> --- a/hw/scsi/spapr_vscsi.c
> +++ b/hw/scsi/spapr_vscsi.c
> @@ -1223,6 +1223,7 @@ static void spapr_vscsi_class_init(ObjectClass *klass, void *data)
>      k->dt_type = "vscsi";
>      k->dt_compatible = "IBM,v-scsi";
>      k->signal_mask = 0x00000001;
> +    set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
>      dc->props = spapr_vscsi_properties;
>      k->rtce_window_size = 0x10000000;
>      dc->vmsd = &vmstate_spapr_vscsi;
> 


-- 
Alexey

Re: [Qemu-devel] [PATCH] spapr: add vio-bus devices to categories

[Alexander Graf]

On 10.10.2013, at 20:08, Alexey Kardashevskiy <aik@ozlabs.ru> wrote:

> In order to get devices appear in output of
> "./qemu-system-ppc64 -device ?",
> they must be assigned to one of DEVICE_CATEGORY_XXXX.
> 
> This puts VIO devices classes to corresponding categories.
> 
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>

Thanks, applied to ppc-next-1.8


Alex